New issue
Advanced search Search tips

Issue 684887 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 657224



Sign in to add a comment

bootstrap.py should filter unsupported options for old cbuildbot versions.

Project Member Reported by dgarr...@chromium.org, Jan 25 2017

Issue description

Currently, bootstrap.py will happily pass along command line options not supported by older versions of cbuildbot, such as "--git-cache-dir".

It should instead use "--reexec-api-version" to discover what options to keep and which to filter.
 
Labels: -current-issue
Owner: dgarr...@chromium.org
Status: Assigned (was: Untriaged)
Blocking: 657224
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/597ddffee1fdf400e457250f8330cbc4b4c4bcd1

commit 597ddffee1fdf400e457250f8330cbc4b4c4bcd1
Author: Don Garrett <dgarrett@google.com>
Date: Thu Mar 02 02:42:13 2017

bootstrap: Filter commandline arguments.

When invoking cbuildbot on older branches, we would pass along
cbuildbot options that didn't exist on the branch. Use cbuildbot's
existing mechanism for filtering command line options that aren't
supported by the old branch.

BUG= chromium:684887 
TEST=run_tests followed by multiple local builds.

Change-Id: Ieb03ca9876618ce9e904a4098d7ee083088fc38b
Reviewed-on: https://chromium-review.googlesource.com/444829
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/597ddffee1fdf400e457250f8330cbc4b4c4bcd1/scripts/cbuildbot.py
[modify] https://crrev.com/597ddffee1fdf400e457250f8330cbc4b4c4bcd1/cbuildbot/remote_try_unittest.py
[modify] https://crrev.com/597ddffee1fdf400e457250f8330cbc4b4c4bcd1/scripts/bootstrap.py
[modify] https://crrev.com/597ddffee1fdf400e457250f8330cbc4b4c4bcd1/cbuildbot/builders/simple_builders_unittest.py
[modify] https://crrev.com/597ddffee1fdf400e457250f8330cbc4b4c4bcd1/scripts/bootstrap_unittest.py
[modify] https://crrev.com/597ddffee1fdf400e457250f8330cbc4b4c4bcd1/cbuildbot/cbuildbot_unittest.py
[modify] https://crrev.com/597ddffee1fdf400e457250f8330cbc4b4c4bcd1/scripts/cbuildbot_unittest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0c54ed7e850804fb764554f0d4815e5a5e20d9d9

commit 0c54ed7e850804fb764554f0d4815e5a5e20d9d9
Author: Don Garrett <dgarrett@google.com>
Date: Tue Mar 07 04:42:33 2017

bootstrap: bootstrap -> cbuildbot_launch.

Bootstrap is a heavily overloaded term, and I wanted to pick something
better before this goes into production and becomes locked down.

This script runs at TOT, and lauches cbuildbot to perform a build an a
branch (or not) in a safe way.

BUG= chromium:684887 
TEST=run_tests

Change-Id: Ia375ea2e920d6b4ade7d2d735798b237221c1aa2
Reviewed-on: https://chromium-review.googlesource.com/449026
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Autumn Quinn <autumn@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[rename] https://crrev.com/0c54ed7e850804fb764554f0d4815e5a5e20d9d9/scripts/cbuildbot_launch_unittest
[rename] https://crrev.com/0c54ed7e850804fb764554f0d4815e5a5e20d9d9/scripts/cbuildbot_launch.py
[rename] https://crrev.com/0c54ed7e850804fb764554f0d4815e5a5e20d9d9/scripts/cbuildbot_launch
[rename] https://crrev.com/0c54ed7e850804fb764554f0d4815e5a5e20d9d9/scripts/cbuildbot_launch_unittest.py

Status: Fixed (was: Started)

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment