New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684879 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Support Interface versioning for JS bindings

Project Member Reported by wangjimmy@chromium.org, Jan 25 2017

Issue description

Support Interface versioning for JS bindings
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43ca78b29ea7366bbbc35e28a272fb145771181f

commit 43ca78b29ea7366bbbc35e28a272fb145771181f
Author: wangjimmy <wangjimmy@chromium.org>
Date: Tue Feb 14 22:08:26 2017

Add interface versioning for javascript.

Methods queryVersion and requireVersion are added to InterfacePtrController.
Support sending and handling control messages by creating control_message_proxy
and control_message_handler. control_message_proxy uses promises as opposed to
callbacks which is what our original cpp code does.

BUG= 684879 
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2676443005
Cr-Commit-Position: refs/heads/master@{#450488}

[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/content/BUILD.gn
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/content/content_resources.grd
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/content/renderer/mojo_context_state.cc
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/ios/web/BUILD.gn
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/ios/web/ios_web_resources.grd
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/ios/web/webui/crw_web_ui_manager.mm
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/js/BUILD.gn
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/js/bindings.js
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/js/constants.cc
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/js/constants.h
[add] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/js/lib/control_message_handler.js
[add] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/js/lib/control_message_proxy.js
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/js/router.js
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/js/tests/interface_ptr_unittest.js
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/js/validator.js
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl
[modify] https://crrev.com/43ca78b29ea7366bbbc35e28a272fb145771181f/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl

Status: Fixed (was: Untriaged)

Sign in to add a comment