New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684805 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 688629



Sign in to add a comment

Componentize safe_browsing::PingManager

Project Member Reported by jialiul@chromium.org, Jan 24 2017

Issue description

Refactor chrome/browser/safe_browsing/ping_manager.* to break down its dependencies with protocol_manager, chunk_range and etc. And move it into components/safe_browsing. 
 

Comment 1 by vakh@chromium.org, Jan 24 2017

So it looks like you only need "struct SafeBrowsingProtocolConfig" from chrome/browser/safe_browsing/protocol_manager_helper.h

This can be moved into "components/safe_browsing_db/util.h" which is already included in chrome/browser/safe_browsing/ping_manager.h

Comment 2 by vakh@chromium.org, Jan 24 2017

Wait, I take that back partially -- it does need the other methods defined in that file.

However, that file can just be removed and its contents placed in components/safe_browsing_db/util.*
Blocking: 688629
Components: Mobile>WebView
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d06419a9457679d7daf3e513c3f72431233ca708

commit d06419a9457679d7daf3e513c3f72431233ca708
Author: jialiul <jialiul@chromium.org>
Date: Mon Feb 27 19:40:11 2017

Componentize ping_manager

Consolidate functions in ProtocolManagerHelper and put them inside
components/safe_browsing_db/util.*.
Separate BasePingManager and SafeBrowsingPingManager, where:
BasePingManager handles basic safe browsing pings such as HitReport,
ThreatDetails report etc.
Leave NotificationImageReport and PermissionReport to
SafeBrowsingPingManager due to their chrome/browser/ dependencies.
BUG= 684805 

Review-Url: https://codereview.chromium.org/2650973005
Cr-Commit-Position: refs/heads/master@{#453300}

[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/browser/BUILD.gn
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/browser/extensions/blacklist_state_fetcher.cc
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/browser/extensions/blacklist_state_fetcher.h
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/browser/safe_browsing/ping_manager.cc
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/browser/safe_browsing/ping_manager.h
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/browser/safe_browsing/protocol_manager.cc
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/browser/safe_browsing/protocol_manager.h
[delete] https://crrev.com/cb3da9c98f24a2fe73a40d490548e1a9acf1df1d/chrome/browser/safe_browsing/protocol_manager_helper.cc
[delete] https://crrev.com/cb3da9c98f24a2fe73a40d490548e1a9acf1df1d/chrome/browser/safe_browsing/protocol_manager_helper.h
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/browser/safe_browsing/test_safe_browsing_service.h
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/chrome/test/BUILD.gn
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/components/safe_browsing/BUILD.gn
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/components/safe_browsing/DEPS
[add] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/components/safe_browsing/base_ping_manager.cc
[add] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/components/safe_browsing/base_ping_manager.h
[rename] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/components/safe_browsing/base_ping_manager_unittest.cc
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/components/safe_browsing_db/BUILD.gn
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/components/safe_browsing_db/DEPS
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/components/safe_browsing_db/util.cc
[modify] https://crrev.com/d06419a9457679d7daf3e513c3f72431233ca708/components/safe_browsing_db/util.h

Status: Fixed (was: Assigned)

Sign in to add a comment