New issue
Advanced search Search tips

Issue 684796 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
xiy...@chromium.org
abodenha@chromium.org
r...@chromium.org
tbarzic@chromium.org
alemate@chromium.org
wzang@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Setting flags through chrome://flags does not work on desktop build of Chrome OS

Project Member Reported by tbarzic@chromium.org, Jan 24 2017 
On desktop Chrome OS build (primarily used for development), settings flags through chrome://flags will have no effect.

Clicking Restart button in chrome://flags UI will only close the current browser, without starting new browser instance (with amended flags).
Upon next Chrome launch, flags set in flags UI will not be added to the command line, nor applied to the current session.

It gets worse in case chrome is launched with --login-manager flag - in that case, when the user that changed their flags logs in, Chrome will attempt restart to apply new set of flags, but after Chrome exits, a new Chrome instance will not be started.

This is expected given that Chrome OS session manager is in charge of actually restarting Chrome - Chrome will just exit and leave it to session manager to start new browser with appropriate set of flags.
When running on desktop, stub session manager does no such thing.

I'm sure that it's too important to get stub session manager to emulate restart behavior, but for starters. we might want to fix the issue with --login-manager flag.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/827ca1c2f792da3147275ea3c3ad0134f708d59f

commit 827ca1c2f792da3147275ea3c3ad0134f708d59f
Author: tbarzic <tbarzic@chromium.org>
Date: Wed Jan 25 19:38:09 2017

Do not restart Chrome to apply user flags with stub session manager

This prevents restarting Chrome to apply per-user flags when not
running on Chrome OS - since Chrome OS session manager, which
initiates browser restart, does not run on desktop build of
Chrome OS, browser restart to apply user flags will not work.
All that would happen is browser shutdown.

Instead uf using SysInfo::IsRunningOnChromeOS directly, add
information about whether session manager supports restart to
session manager client - this will enable us to enable restart
behaviour in tests when needed, e.g. for tests that test browser
restart flow.

BUG= 684796 

Review-Url: https://codereview.chromium.org/2653823004
Cr-Commit-Position: refs/heads/master@{#446088}

[modify] https://crrev.com/827ca1c2f792da3147275ea3c3ad0134f708d59f/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/827ca1c2f792da3147275ea3c3ad0134f708d59f/chrome/browser/chromeos/settings/device_settings_test_helper.cc
[modify] https://crrev.com/827ca1c2f792da3147275ea3c3ad0134f708d59f/chrome/browser/chromeos/settings/device_settings_test_helper.h
[modify] https://crrev.com/827ca1c2f792da3147275ea3c3ad0134f708d59f/chromeos/dbus/fake_session_manager_client.cc
[modify] https://crrev.com/827ca1c2f792da3147275ea3c3ad0134f708d59f/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/827ca1c2f792da3147275ea3c3ad0134f708d59f/chromeos/dbus/mock_session_manager_client.h
[modify] https://crrev.com/827ca1c2f792da3147275ea3c3ad0134f708d59f/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/827ca1c2f792da3147275ea3c3ad0134f708d59f/chromeos/dbus/session_manager_client.h

Comment 2 by st...@chromium.org, Mar 3 2017

Cc: r...@chromium.org

Comment 3 by st...@chromium.org, Mar 3 2017

Cc: -st...@chromium.org
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 7 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by alemate@chromium.org, Mar 8 2018

Status: Fixed (was: Untriaged)
I think Toni has already fixed this to the reasonable level that he described in the description.
►

Sign in to add a comment