New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684749 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Media Remoting: Exit remoting only if playback is continuously delayed.

Project Member Reported by x...@chromium.org, Jan 24 2017

Issue description

The local time to process the TimeUpdate RPC message is used to detect
whether playback is delayed. Since the RPC message might not be
processed in time, only exits remoting if playback is continously
delayed.
 

Comment 2 by x...@chromium.org, Jan 24 2017

Status: Fixed (was: Started)

Comment 3 by x...@chromium.org, Jan 24 2017

Labels: M-57 Merge-Request-57
Requesting to merge to M57. Low risk.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 25 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 25 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa1af7df4e21b4157fec59bc994ded8095b90b3

commit caa1af7df4e21b4157fec59bc994ded8095b90b3
Author: xjz <xjz@chromium.org>
Date: Wed Jan 25 23:48:08 2017

Media Remoting: Exit remoting only if playback is continuously delayed.

The local time to process the TimeUpdate RPC message is used to detect
whether playback is delayed. Since the RPC message might not be
processed in time, only exits remoting if playback is continously
delayed.

BUG= 684749 

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2638393005
Cr-Original-Commit-Position: refs/heads/master@{#445136}
Review-Url: https://codereview.chromium.org/2649043011
Cr-Commit-Position: refs/branch-heads/2987@{#97}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/caa1af7df4e21b4157fec59bc994ded8095b90b3/media/remoting/remote_renderer_impl.cc
[modify] https://crrev.com/caa1af7df4e21b4157fec59bc994ded8095b90b3/media/remoting/remote_renderer_impl.h

Sign in to add a comment