The PCMWaveInAudioInputStream legacy implementation exists for XP and Vista support and according to the latest stats*, is showing to have issues. The other implementation, is doing much better so we should do away with the old implementation (XP and Vista are no longer supported). * https://uma.googleplex.com/p/chrome/histograms/?endDate=20170123&dayCount=5&histograms=Media.Audio.Capture.CallbackError%2CMedia.AudioInputControllerCaptureStartupSuccess&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cversion_tags%2Ccnt%2CD%2Cplatform%2Ceq%2CW%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a589a11cc8809c88d62b32a5810d6994fad45aaa commit a589a11cc8809c88d62b32a5810d6994fad45aaa Author: tommi <tommi@chromium.org> Date: Thu Jan 26 21:49:06 2017 Remove the wave based audio capture implementation for Windows BUG= 684741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2646423005 Cr-Commit-Position: refs/heads/master@{#446459} [modify] https://crrev.com/a589a11cc8809c88d62b32a5810d6994fad45aaa/media/audio/BUILD.gn [modify] https://crrev.com/a589a11cc8809c88d62b32a5810d6994fad45aaa/media/audio/audio_manager_unittest.cc [modify] https://crrev.com/a589a11cc8809c88d62b32a5810d6994fad45aaa/media/audio/win/audio_device_listener_win.cc [modify] https://crrev.com/a589a11cc8809c88d62b32a5810d6994fad45aaa/media/audio/win/audio_manager_win.cc [modify] https://crrev.com/a589a11cc8809c88d62b32a5810d6994fad45aaa/media/audio/win/audio_manager_win.h [modify] https://crrev.com/a589a11cc8809c88d62b32a5810d6994fad45aaa/media/audio/win/core_audio_util_win.cc [modify] https://crrev.com/a589a11cc8809c88d62b32a5810d6994fad45aaa/media/audio/win/device_enumeration_win.cc [modify] https://crrev.com/a589a11cc8809c88d62b32a5810d6994fad45aaa/media/audio/win/device_enumeration_win.h [delete] https://crrev.com/a8f908ca6ab0abe86af75c688099d8c9dee1685c/media/audio/win/wavein_input_win.cc [delete] https://crrev.com/a8f908ca6ab0abe86af75c688099d8c9dee1685c/media/audio/win/wavein_input_win.h [modify] https://crrev.com/a589a11cc8809c88d62b32a5810d6994fad45aaa/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9647273a0f14390552564183f519635cf5f6f1f7 commit 9647273a0f14390552564183f519635cf5f6f1f7 Author: tommi <tommi@chromium.org> Date: Wed Feb 01 15:51:53 2017 Revert a behavioral change in AudioManagerWin::GetInputStreamParameters. This CL reverts a part of a change landed last week: https://codereview.chromium.org/2646423005 From the canary data it looks like some code paths still depend on the previous behavior. BUG= 684741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2667843007 Cr-Commit-Position: refs/heads/master@{#447518} [modify] https://crrev.com/9647273a0f14390552564183f519635cf5f6f1f7/media/audio/win/audio_manager_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3234f6bb6cfd0343aac4755271f2b8697a8cde49 commit 3234f6bb6cfd0343aac4755271f2b8697a8cde49 Author: tommi <tommi@chromium.org> Date: Thu Feb 09 18:37:57 2017 Add UMA stats to track down issues with opening "high latency" (aka linear) audio input streams on Windows and fix memory leak that appears to have been there for a long while. BUG= 684741 , 689976 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2680873002 Cr-Commit-Position: refs/heads/master@{#449359} [modify] https://crrev.com/3234f6bb6cfd0343aac4755271f2b8697a8cde49/media/audio/win/audio_low_latency_input_win.cc [modify] https://crrev.com/3234f6bb6cfd0343aac4755271f2b8697a8cde49/media/audio/win/audio_low_latency_input_win.h [modify] https://crrev.com/3234f6bb6cfd0343aac4755271f2b8697a8cde49/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d875dfaa149b616ef07c753b4ad55777b636c7e commit 3d875dfaa149b616ef07c753b4ad55777b636c7e Author: tommi <tommi@chromium.org> Date: Sat Feb 18 14:19:06 2017 Add basic resample support to WASAPIAudioInputStream. After removing the legacy Wave capture implementation, we're seeing frequent failures on Windows due to "FORMAT_NOT_SUPPORTED". It seems we still have places that hardcode a specific sample rate instead of querying. This CL adds basic support for resampling to see how much that buys us while we track down the code that still requires this. Notably we don't support cases where there are mismatches in the number of channels etc, so there will possibly still be cases where a user has a mono mic but the calling code has hardcoded requiring stereo input. BUG= 684741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2690793002 Cr-Commit-Position: refs/heads/master@{#451461} [modify] https://crrev.com/3d875dfaa149b616ef07c753b4ad55777b636c7e/media/audio/win/audio_low_latency_input_win.cc [modify] https://crrev.com/3d875dfaa149b616ef07c753b4ad55777b636c7e/media/audio/win/audio_low_latency_input_win.h [modify] https://crrev.com/3d875dfaa149b616ef07c753b4ad55777b636c7e/media/audio/win/audio_low_latency_input_win_unittest.cc [modify] https://crrev.com/3d875dfaa149b616ef07c753b4ad55777b636c7e/media/base/audio_block_fifo.cc [modify] https://crrev.com/3d875dfaa149b616ef07c753b4ad55777b636c7e/media/base/audio_block_fifo.h [modify] https://crrev.com/3d875dfaa149b616ef07c753b4ad55777b636c7e/media/base/audio_block_fifo_unittest.cc [modify] https://crrev.com/3d875dfaa149b616ef07c753b4ad55777b636c7e/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Jan 26 2017