New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684701 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 684669



Sign in to add a comment

No configured buildbucket bucket for Chromeos_release waterfall

Project Member Reported by nxia@chromium.org, Jan 24 2017

Issue description

R57 complains about no buildbucket bucket configuration for Chromeos_release. 

https://luci-logdog.appspot.com/v/?s=chromeos%2Fbb%2Fchromeos_release%2Fmaster-release_release-R57-9202.B%2F1%2F%2B%2Frecipes%2Fsteps%2FScheduleSlaves%2F0%2Fstdout

NoBuildbucketBucketFoundException: No Buildbucket bucket found for builder mccloud-release waterfall: chromeos_release


R56 have to use git-commit scheduler, so we cannot just enable buildbucket scheduler and un-register git-commit scheduler in chromeos_release waterfall.

R57 still triggers slaves using git-commit and runs successfully (except the error logging in ScheduleSlaves). Propose to patch R57 to un-register its buildbucket scheduler now. When we move to R58 and don't need to support R56 anymore, we then turn on buildbucket scheduler on chromeos_release waterfall and un-register git-commit scheduler.

 

Comment 1 by nxia@chromium.org, Jan 24 2017

Cc: pprabhu@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3425664c93de4dfbda1c5f4a45d8642c371f2dc9

commit 3425664c93de4dfbda1c5f4a45d8642c371f2dc9
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Jan 24 22:13:41 2017

Do not use Buildbucket scheduler for masters in chromeos_release.

Currently chromeos_release waterfall still needs git-commit scheduler
for R56 branch. Plan to remove the buildbucket scheduler for
R57 master in chromeos_release waterfall, and enable Buildbucket
scheduler when all masters in chromeos_releases use Buildbucket.

BUG= chromium:684701 
TEST=unit_tests

Change-Id: Id3f1e439ecab8853d7df84d1566d732adbe6943c
Reviewed-on: https://chromium-review.googlesource.com/432004
Trybot-Ready: Ningning Xia <nxia@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/3425664c93de4dfbda1c5f4a45d8642c371f2dc9/cbuildbot/build_status_unittest.py
[modify] https://crrev.com/3425664c93de4dfbda1c5f4a45d8642c371f2dc9/lib/config_lib_unittest.py
[modify] https://crrev.com/3425664c93de4dfbda1c5f4a45d8642c371f2dc9/lib/config_lib.py
[modify] https://crrev.com/3425664c93de4dfbda1c5f4a45d8642c371f2dc9/cbuildbot/manifest_version_unittest.py

Comment 3 by nxia@chromium.org, Jan 25 2017

Blocking: 684669

Comment 4 by nxia@chromium.org, Jan 25 2017

Cc: keta...@chromium.org
Labels: Merge-Request-57
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 25 2017

Labels: merge-merged-release-R57-9202.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e504fa2b75c6db216b78f53b0479b6aba2fe5d14

commit e504fa2b75c6db216b78f53b0479b6aba2fe5d14
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Jan 24 22:13:41 2017

Do not use Buildbucket scheduler for masters in chromeos_release.

Currently chromeos_release waterfall still needs git-commit scheduler
for R56 branch. Plan to remove the buildbucket scheduler for
R57 master in chromeos_release waterfall, and enable Buildbucket
scheduler when all masters in chromeos_releases use Buildbucket.

BUG= chromium:684701 
TEST=unit_tests

Change-Id: Id3f1e439ecab8853d7df84d1566d732adbe6943c
Reviewed-on: https://chromium-review.googlesource.com/432041
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/e504fa2b75c6db216b78f53b0479b6aba2fe5d14/cbuildbot/build_status_unittest.py
[modify] https://crrev.com/e504fa2b75c6db216b78f53b0479b6aba2fe5d14/lib/config_lib_unittest.py
[modify] https://crrev.com/e504fa2b75c6db216b78f53b0479b6aba2fe5d14/lib/config_lib.py
[modify] https://crrev.com/e504fa2b75c6db216b78f53b0479b6aba2fe5d14/cbuildbot/manifest_version_unittest.py

Status: Started (was: Untriaged)
I think this is Fixed now.

Comment 8 by nxia@chromium.org, Jan 26 2017

Status: Fixed (was: Started)
Project Member

Comment 9 by sheriffbot@chromium.org, Jan 30 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-57
sheriffbot doesn't like the merge-request label.

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment