Issue metadata
Sign in to add a comment
|
Glitch Column dividers on Gdrive |
|||||||||||||||||||||
Issue descriptionChrome Version: 9202.1.0, 57.0.2987.6 Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1)Open File apps (2)Check the column dividers Expected Result: No overap with contents Actual Result:Overlaps with the contents How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Only on GDrive columns What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 25 2017
Hi - Can you verify if this is a device specific bug? I am on the same version on a lulu and was not able to reproduce this behavior.
,
Jan 25 2017
@weifangsun - This is not device specific bug. Tested on lulu device on Version 57.0.2987.8/9202.4.0 and its exists Note:- This is found only on Drive columns and its regression which started from the branch build 9202.1.0 . 9202.0.0 build is fine.
,
Jan 25 2017
LuLu device was on 9202.0.0 issue not there . Updated to 9202.4.0 now the bug appears. Device is on default resolution nothing changed. And seeing this on rest of our team devices too . Can you please test on another device to confirm?
,
Jan 25 2017
Tested on a Kevin and see it now, but not at the size of window in your previous screenshot - Had to shrink the window very small to reproduce. Thanks!
,
Jan 26 2017
I can reproduce this, too. yamaguchi@, do you have cycles to look into this one? If this occurs, this issue should be very visible to users.
,
Jan 26 2017
Now I took a quick look and observed some repro. It seems not specific to Drive folders. It is related to whether the list of the files in a folder shows a vertical scroll bar or not. (can see difference by resizing a window) I also noticed that the overlay scrollbar is not ON by default. It'd be helpful if someone else can double check.
,
Jan 26 2017
It seems this always reproduces when there are enough files to show the scroll bar. We should definitely fix this regression. yamaguchi@, is this related to the replacement of custom scroll bar? If the overlay scrollbar is not available, maybe we should revert the change?
,
Jan 26 2017
This happens when the overlay scrollbar of Blink is disabled by the option and thus showing the solid scrollbars. The team decided to disable it on M57 as described in another bug. https://bugs.chromium.org/p/chromium/issues/detail?id=307091#c124 So we will revert the change in order to get the same design as M56. If we revert the change, this issue will no longer be visible. We still need to fix the issue on M58, if we will enable the overlay scrollbar in Blink.
,
Jan 26 2017
> We still need to fix the issue on M58, if we will enable the overlay scrollbar in Blink. Note that it would be visible only when a user turns off the overlay_scrollbars at about:flags then.
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/526e1938a4fef1e70e97295715b581d79a51574c commit 526e1938a4fef1e70e97295715b581d79a51574c Author: yamaguchi <yamaguchi@chromium.org> Date: Thu Jan 26 14:39:17 2017 Revert of Replace homebrew scrollbar in Files app with that of Blink. (patchset #3 id:40001 of https://codereview.chromium.org/2554433002/ ) Reason for revert: Overlay scrollbar in Blink will be disabled on M57. https://bugs.chromium.org/p/chromium/issues/detail?id=307091#c124 Original issue's description: > Replace homebrew scrollbar in Files app with that of Blink. > > When overlay scrollbar is enabled in Chrome, there is animation to shrink and fade out the scrollbar thumb when inactive. However, scroll bars that aren't composited will not be animated > (see Issue 671644 ). It would make the scroll bar always thick and simply disappear without fading out after inactive. > As a workaround, this change makes the 2 boxes have solid background and contain:paint so as to make sure the scrollers are composited. > > BUG= 666589 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/fa7b28294ab9ee7e07569054d4e65626e2535f4e > Cr-Commit-Position: refs/heads/master@{#436868} TBR=fukino@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 666589 , 684695 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654873006 Cr-Commit-Position: refs/heads/master@{#446323} [modify] https://crrev.com/526e1938a4fef1e70e97295715b581d79a51574c/ui/file_manager/file_manager/foreground/css/file_manager.css [modify] https://crrev.com/526e1938a4fef1e70e97295715b581d79a51574c/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp [modify] https://crrev.com/526e1938a4fef1e70e97295715b581d79a51574c/ui/file_manager/file_manager/foreground/js/main_scripts.js [modify] https://crrev.com/526e1938a4fef1e70e97295715b581d79a51574c/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/526e1938a4fef1e70e97295715b581d79a51574c/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html [modify] https://crrev.com/526e1938a4fef1e70e97295715b581d79a51574c/ui/file_manager/file_manager/foreground/js/ui/file_grid.js [modify] https://crrev.com/526e1938a4fef1e70e97295715b581d79a51574c/ui/file_manager/file_manager/foreground/js/ui/file_table.js [add] https://crrev.com/526e1938a4fef1e70e97295715b581d79a51574c/ui/file_manager/file_manager/foreground/js/ui/scrollbar.js
,
Jan 27 2017
,
Jan 27 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 31 2017
ping for merge review.
,
Feb 3 2017
For future reference please add Merge-Request-57 as a label instead of Merge-Review-57. Approving for merge to M57.
,
Feb 3 2017
Approving merge to M57 Chrome OS.
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5 commit e50697019dd8e4092b07607e7cf9f3f4fbc8aef5 Author: yamaguchi <yamaguchi@chromium.org> Date: Mon Feb 06 02:36:45 2017 Revert of Replace homebrew scrollbar in Files app with that of Blink. (patchset #3 id:40001 of https://codereview.chromium.org/2554433002/ ) Reason for revert: Overlay scrollbar in Blink will be disabled on M57. https://bugs.chromium.org/p/chromium/issues/detail?id=307091#c124 Original issue's description: > Replace homebrew scrollbar in Files app with that of Blink. > > When overlay scrollbar is enabled in Chrome, there is animation to shrink and fade out the scrollbar thumb when inactive. However, scroll bars that aren't composited will not be animated > (see Issue 671644 ). It would make the scroll bar always thick and simply disappear without fading out after inactive. > As a workaround, this change makes the 2 boxes have solid background and contain:paint so as to make sure the scrollers are composited. > > BUG= 666589 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/fa7b28294ab9ee7e07569054d4e65626e2535f4e > Cr-Commit-Position: refs/heads/master@{#436868} TBR=fukino@chromium.org BUG= 666589 , 684695 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654873006 Cr-Commit-Position: refs/heads/master@{#446323} (cherry picked from commit 526e1938a4fef1e70e97295715b581d79a51574c) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2657143002 Cr-Commit-Position: refs/branch-heads/2987@{#315} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5/ui/file_manager/file_manager/foreground/css/file_manager.css [modify] https://crrev.com/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp [modify] https://crrev.com/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5/ui/file_manager/file_manager/foreground/js/main_scripts.js [modify] https://crrev.com/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html [modify] https://crrev.com/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5/ui/file_manager/file_manager/foreground/js/ui/file_grid.js [modify] https://crrev.com/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5/ui/file_manager/file_manager/foreground/js/ui/file_table.js [add] https://crrev.com/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5/ui/file_manager/file_manager/foreground/js/ui/scrollbar.js
,
Feb 6 2017
,
Feb 16 2017
Verified on 9202.28.0 / 57.0.2987.54
,
May 25 2017
,
May 26 2017
Looks like we need to CP fix into M59
,
May 26 2017
Please request merge to 59
,
May 26 2017
,
May 26 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2017
Requesting merge of https://codereview.chromium.org/2914573003/ to M59. The patch is for M59 release branch and was created for fixing the issue described in Comment 21.
,
May 30 2017
This bug requires manual review: Only 6 days from stable, we might already have a stable candidate build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 31 2017
Let me explain a bit more: The issue described in Comment 21 cannot be fixed by cherry-picking a patch from master. We cannot make the fix in master neither, because that will cause another issue on the master. Therefore I created a patch https://codereview.chromium.org/2914573003/ on top of the M59 release branch. We'd like to merge this to M59.
,
May 31 2017
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47e91004c618d26d32ce0a7d1803720affa72489 commit 47e91004c618d26d32ce0a7d1803720affa72489 Author: yamaguchi <yamaguchi@chromium.org> Date: Thu Jun 01 00:53:16 2017 M59: Revert of "Replace homebrew scrollbar in Files app with that of Blink." (patchset #3 id:40001 of https://codereview.chromium.org/2782063002/ ) Reason for revert: We don't enable native overlay scrollbar by default on M59. The Files app should continue using the older scrollbar that was built for the app. Original issue's description: > Reland of "Replace homebrew scrollbar in Files app with that of Blink." > > This changelist is based on the revert patch of commit e50697019dd8e4092b07607e7cf9f3f4fbc8aef5. > > > BUG= 666589 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2782063002 > Cr-Commit-Position: refs/heads/master@{#460290} > Committed: https://chromium.googlesource.com/chromium/src/+/c4faf5fee6fab54abd2e49a5e2170434c0440914 # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 684695 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2914573003 Cr-Commit-Position: refs/branch-heads/3071@{#733} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/47e91004c618d26d32ce0a7d1803720affa72489/ui/file_manager/file_manager/foreground/css/file_manager.css [modify] https://crrev.com/47e91004c618d26d32ce0a7d1803720affa72489/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp [modify] https://crrev.com/47e91004c618d26d32ce0a7d1803720affa72489/ui/file_manager/file_manager/foreground/js/main_scripts.js [modify] https://crrev.com/47e91004c618d26d32ce0a7d1803720affa72489/ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp [modify] https://crrev.com/47e91004c618d26d32ce0a7d1803720affa72489/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/47e91004c618d26d32ce0a7d1803720affa72489/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html [modify] https://crrev.com/47e91004c618d26d32ce0a7d1803720affa72489/ui/file_manager/file_manager/foreground/js/ui/file_grid.js [modify] https://crrev.com/47e91004c618d26d32ce0a7d1803720affa72489/ui/file_manager/file_manager/foreground/js/ui/file_table.js [add] https://crrev.com/47e91004c618d26d32ce0a7d1803720affa72489/ui/file_manager/file_manager/foreground/js/ui/scrollbar.js
,
Jun 1 2017
Does the revert here temporarily fix the issue?
,
Jun 2 2017
Yes, it will fix the issue on M59.
,
Jun 2 2017
,
Jun 6 2017
Anything extra needed for M-60 here?
,
Jun 7 2017
I think no extra task is needed for M-60 unless we find the same issue there.
,
Jun 13 2017
ok, seems like all is merged then, please mark as fixed if no more work remaining
,
Jul 11 2017
Marking as fixed, because now this issue will not be reproducible as we enabled overlay scrollbar with the current release.
,
Jul 13 2017
9460.67.0, 59.0.3071.113 |
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by rookrishna@chromium.org
, Jan 24 2017