New issue
Advanced search Search tips

Issue 684691 link

Starred by 2 users
Status: Fixed
Owner:
sahel@chromium.org
Closed: Sep 2017
Cc:
dtapu...@chromium.org
tdres...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 526463


Sign in to add a comment

Clean up the unused scroll_update.data.scrollUpdate.preventPropagation boolean variable

Project Member Reported by sahel@chromium.org, Jan 24 2017 
With touch scroll latching being enabled, scroll_update.data.scrollUpdate.preventPropagation is never read anywhere,
its getter function always returns true.

Clean up the code and get rid of the variable and its getter as well as should_propagate in cc.

Comment 1 by dtapu...@chromium.org, Feb 1 2017

Components: Blink>Input
Labels: Hotlist-Input-Dev
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf557ff0164d388c8d36083fe625098f1eec5e26

commit cf557ff0164d388c8d36083fe625098f1eec5e26
Author: Sahel Sharify <sahel@chromium.org>
Date: Tue Sep 19 10:16:52 2017

clean up unused scroll_update.prevent_propagation

Bug:  684691 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5ebf3fcff043b01f02fdbabdaf171fa13e838392
Reviewed-on: https://chromium-review.googlesource.com/658277
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502818}
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/cc/input/scroll_state.h
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/cc/input/scroll_state_data.cc
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/cc/input/scroll_state_data.h
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/cc/trees/property_tree.cc
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/content/common/input/input_event_struct_traits.cc
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/content/common/input/input_handler.mojom
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/content/shell/test_runner/event_sender.cc
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-scroll-by-page.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-scroll-by-pixel.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-fully-scrolled-iframe-propagates.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-input-field.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/plugins/gesture-events-scrolled.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/LayoutTests/plugins/gesture-events.html
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/Source/core/events/WebInputEventConversionTest.cpp
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/Source/core/page/scrolling/ScrollState.h
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/Source/core/page/scrolling/ScrollState.idl
[modify] https://crrev.com/cf557ff0164d388c8d36083fe625098f1eec5e26/third_party/WebKit/public/platform/WebGestureEvent.h

Comment 3 by sahel@chromium.org, Sep 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment