New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684686 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer: Try jobs not started automatically

Project Member Reported by lijeffrey@chromium.org, Jan 24 2017

Issue description

Labels: -Pri-1 Pri-0
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/1b7ba8786d859c1bfb4f9167444a3c31b9169e9d

commit 1b7ba8786d859c1bfb4f9167444a3c31b9169e9d
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Jan 25 00:35:29 2017

[Findit] Flake analyzer - Fixing flake try jobs not starting

The problem is _UpdateAnalysisStatusUponCompletion is called too late, which is responsible for setting suspected_flake_build_number. Without that, GetDataPointOfSuspectedBuild() returns None, causing try jobs to bail out. This change calls update first so the information to run try jobs is read correctly.

BUG= 684686 

Change-Id: I48151409f90530f0fd235a38222797547ac1a1b3
Reviewed-on: https://chromium-review.googlesource.com/432005
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/1b7ba8786d859c1bfb4f9167444a3c31b9169e9d/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/1b7ba8786d859c1bfb4f9167444a3c31b9169e9d/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment