New issue
Advanced search Search tips

Issue 684682 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Form-Not-Secure "Learn more" link should open Page Info

Project Member Reported by est...@chromium.org, Jan 24 2017

Issue description

The "Learn more" link in the Form-Not-Secure warning should open Page Info. (Currently it links to the help center).
 
Cc: est...@chromium.org
Owner: elawrence@chromium.org
Status: Started (was: Assigned)
Cc: -est...@chromium.org elawrence@chromium.org
Owner: est...@chromium.org
Oops. Emily already started the review; https://codereview.chromium.org/2650033004/
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c83163e85da7ed3dc54a0dd21bf1954f2643459c

commit c83163e85da7ed3dc54a0dd21bf1954f2643459c
Author: estark <estark@chromium.org>
Date: Thu Jan 26 22:30:55 2017

Show Page Info from Form-Not-Secure 'Learn more' link

Instead of directly opening a tab to the Help Center, the "Learn more" link
should open the Page Info bubble. From there the user can click another link to
open the Help Center, if they want.

BUG= 684682 
TEST=Enable #enable-http-form-warning. Visit http://rsolomakhin.github.io.
Fill out the Name/Password form and submit it and save the password. Go back
to http://rsolomakhin.github.io and focus the Password field. Observe the
"Login not secure" warning in the autofill dropdown and click it. Observe that
the Page Info bubble opens down from the omnibox.

Review-Url: https://codereview.chromium.org/2650033004
Cr-Commit-Position: refs/heads/master@{#446469}

[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/chromeos/login/ui/simple_web_view_dialog.h
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/chrome/browser/ui/views/toolbar/toolbar_view.h
[modify] https://crrev.com/c83163e85da7ed3dc54a0dd21bf1954f2643459c/components/password_manager/core/browser/password_autofill_manager_unittest.cc

Comment 4 by est...@chromium.org, Jan 26 2017

Status: Fixed (was: Started)

Comment 5 by est...@chromium.org, Jan 28 2017

Labels: Merge-Request-57

Comment 6 by est...@chromium.org, Jan 30 2017

Fix has been baking on canary for several days and I verified it.
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 30 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1e7d7ff6eed446848c90fee771487669ba4466f

commit e1e7d7ff6eed446848c90fee771487669ba4466f
Author: Emily Stark <estark@google.com>
Date: Mon Jan 30 19:00:57 2017

Show Page Info from Form-Not-Secure 'Learn more' link

Instead of directly opening a tab to the Help Center, the "Learn more" link
should open the Page Info bubble. From there the user can click another link to
open the Help Center, if they want.

BUG= 684682 
TEST=Enable #enable-http-form-warning. Visit http://rsolomakhin.github.io.
Fill out the Name/Password form and submit it and save the password. Go back
to http://rsolomakhin.github.io and focus the Password field. Observe the
"Login not secure" warning in the autofill dropdown and click it. Observe that
the Page Info bubble opens down from the omnibox.

Review-Url: https://codereview.chromium.org/2650033004
Cr-Commit-Position: refs/heads/master@{#446469}
(cherry picked from commit c83163e85da7ed3dc54a0dd21bf1954f2643459c)

Review-Url: https://codereview.chromium.org/2660293002 .
Cr-Commit-Position: refs/branch-heads/2987@{#170}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/chromeos/login/ui/simple_web_view_dialog.h
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/browser/ui/views/toolbar/toolbar_view.h
[modify] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/components/password_manager/core/browser/password_autofill_manager_unittest.cc

Sign in to add a comment