Starting with FCP.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fc1646fa5e8434223f2bce7b977fdbb7e2904b6 commit 2fc1646fa5e8434223f2bce7b977fdbb7e2904b6 Author: oysteine <oysteine@chromium.org> Date: Tue Jan 24 23:56:12 2017 Added accessor for the ukm service to the browser process singleton Split out from https://codereview.chromium.org/2617883004/ R=holte@chromium.org,sky@chromium.org BUG= 684673 Review-Url: https://codereview.chromium.org/2649983005 Cr-Commit-Position: refs/heads/master@{#445866} [modify] https://crrev.com/2fc1646fa5e8434223f2bce7b977fdbb7e2904b6/chrome/browser/browser_process.h [modify] https://crrev.com/2fc1646fa5e8434223f2bce7b977fdbb7e2904b6/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/2fc1646fa5e8434223f2bce7b977fdbb7e2904b6/chrome/browser/browser_process_impl.h [modify] https://crrev.com/2fc1646fa5e8434223f2bce7b977fdbb7e2904b6/chrome/test/base/testing_browser_process.cc [modify] https://crrev.com/2fc1646fa5e8434223f2bce7b977fdbb7e2904b6/chrome/test/base/testing_browser_process.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8206ba1cdddee202d83e2c468aef524da8ede4b commit f8206ba1cdddee202d83e2c468aef524da8ede4b Author: oysteine <oysteine@chromium.org> Date: Fri Jan 27 23:44:19 2017 UKM: Added support for navigation sources This adds functionality for adding navigation entries as sources for UKM, as well as unittesting utilities. Split out from https://codereview.chromium.org/2617883004/ R=holte@chromium.org,asvitkine@chromium.org BUG= 684673 Review-Url: https://codereview.chromium.org/2649303004 Cr-Commit-Position: refs/heads/master@{#446833} [modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/metrics/proto/ukm/source.proto [modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/BUILD.gn [modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/DEPS [add] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/test_ukm_service.cc [add] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/test_ukm_service.h [modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_service.cc [modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_service.h [modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_service_unittest.cc [add] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_source.cc [add] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_source.h [modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b766497105ee42a5460c69d75c80f9a4858285d3 commit b766497105ee42a5460c69d75c80f9a4858285d3 Author: oysteine <oysteine@chromium.org> Date: Wed Feb 01 19:18:48 2017 Added UkmPageLoadMetricsObserver which sends top-level metrics to UKM Initial minimal version which just logs FirstContentfulPaint. Requires https://codereview.chromium.org/2649303004/ and https://codereview.chromium.org/2649983005/# R=bmcquade@chromium.org BUG= 684673 Review-Url: https://codereview.chromium.org/2654843003 Cr-Commit-Position: refs/heads/master@{#447571} [modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/BUILD.gn [add] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc [add] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h [add] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc [modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/test/BUILD.gn [modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/test/base/testing_browser_process.cc [modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/components/ukm/test_ukm_service.h [modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/components/ukm/ukm_service_unittest.cc [modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/components/ukm/ukm_source.cc [modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/components/ukm/ukm_source.h
Hey Bryan i'd think this is done for what this was intended to capture. Will close - maybe reopen if you want this to track next generation metrics?
Comment 1 by bugdroid1@chromium.org
, Jan 24 2017