New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684673 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocking:
issue 678682



Sign in to add a comment

Send pageload metrics to the URL-Keyed Metrics system

Project Member Reported by oysteine@chromium.org, Jan 24 2017

Issue description

Starting with FCP.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8206ba1cdddee202d83e2c468aef524da8ede4b

commit f8206ba1cdddee202d83e2c468aef524da8ede4b
Author: oysteine <oysteine@chromium.org>
Date: Fri Jan 27 23:44:19 2017

UKM: Added support for navigation sources

This adds functionality for adding navigation entries as sources for UKM,
as well as unittesting utilities.

Split out from https://codereview.chromium.org/2617883004/

R=holte@chromium.org,asvitkine@chromium.org
BUG= 684673 

Review-Url: https://codereview.chromium.org/2649303004
Cr-Commit-Position: refs/heads/master@{#446833}

[modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/metrics/proto/ukm/source.proto
[modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/BUILD.gn
[modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/DEPS
[add] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/test_ukm_service.cc
[add] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/test_ukm_service.h
[modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_service.cc
[modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_service.h
[modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_service_unittest.cc
[add] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_source.cc
[add] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/components/ukm/ukm_source.h
[modify] https://crrev.com/f8206ba1cdddee202d83e2c468aef524da8ede4b/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b766497105ee42a5460c69d75c80f9a4858285d3

commit b766497105ee42a5460c69d75c80f9a4858285d3
Author: oysteine <oysteine@chromium.org>
Date: Wed Feb 01 19:18:48 2017

Added UkmPageLoadMetricsObserver which sends top-level metrics to UKM

Initial minimal version which just logs FirstContentfulPaint.

Requires https://codereview.chromium.org/2649303004/ and https://codereview.chromium.org/2649983005/#

R=bmcquade@chromium.org
BUG= 684673 

Review-Url: https://codereview.chromium.org/2654843003
Cr-Commit-Position: refs/heads/master@{#447571}

[modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/BUILD.gn
[add] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[add] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[add] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/test/BUILD.gn
[modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/components/ukm/test_ukm_service.h
[modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/components/ukm/ukm_service_unittest.cc
[modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/components/ukm/ukm_source.cc
[modify] https://crrev.com/b766497105ee42a5460c69d75c80f9a4858285d3/components/ukm/ukm_source.h

Owner: bmcquade@chromium.org
Status: Fixed (was: Started)
Hey Bryan i'd think this is done for what this was intended to capture. Will close - maybe reopen if you want this to track next generation metrics?

Sign in to add a comment