Don't show icon border for non-Autofill |
||||||||||||
Issue descriptionAndroid Pay and other 3rd party android payment apps can have weird icon dimensions, so we should not show icon border for them.
,
Jan 26 2017
The droid icon seems huge. Did that change recently?
,
Jan 26 2017
zkoch, I actually like the bordered version more. WDYT?
,
Jan 26 2017
Probably, border version for expanded view and no border version for summary?
,
Jan 27 2017
I don't think bordered version ever looks good myself. Adding Bruno for his take.
,
Jan 27 2017
Yes, no border, please. Most app icons have transparent pixels around them (irregular shapes, circles, rounded corners) and a border only emphasizes the mismatch. Two more aspects to consideR: - App icons tend to look bigger than the CC icons, by being square-ish in shape. Can we make them 2 dp smaller in order to have roughly the same visual weight? - Let's also right align all the icons. The 'gravity' in that column is to the right.
,
Jan 27 2017
Do you want the same /height/ for icons, Bruno?
,
Jan 27 2017
Width and height, since the icons are square. It should be right aligned and vertically centered. The attached image shows what I mean by right aligned: even with the icon's transparent pixels it's left boundary is on the blue line, when it should be on the magenta line.
,
Jan 27 2017
yes, that's what I mean, currently we aligned the icons to the right, but it looks not aligned since the droid icon has transparent border. For the size of the icon, we did not set fix size for the icon (depends on icon itself), but set max width of the icon to be 56dp, if the width of the real icon greater than 56dp, it will be scaled to 56dp to preserve its aspect ratio. Moreover, do all Android apps' icon have the same size and border? Otherwise, it looks doesn't make much sense to scale for this specific droid icon.
,
Jan 27 2017
Maybe I'm misunderstanding or not expressing myself clearly. All Android app icon files are square, even if the content isn't, so their size is predictable. But even if they have transparent padding (as this droid icon does), since they're square, they won't take up the same room as the credit card icons, which are rectangular. So we should right-align them, as the attached image shows. Does that make sense?
,
Jan 31 2017
After discussed with bbergher@ offline and struggled a while with the tricky gridlayout, here are the screenshots of the updated UIs. The app icon (24dp for width and height) looks a little bit small in expanded payment section for me, especially compare what it looks like in the selected item view,
,
Jan 31 2017
Final screenshots after communicating offline, changed alignment and icon size. The CL is upload for reviewing soon,
,
Jan 31 2017
Looks great, Ganggui!
,
Feb 3 2017
,
Jun 27 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by gogerald@chromium.org
, Jan 26 2017221 KB
221 KB View Download
142 KB
142 KB View Download
121 KB
121 KB View Download
144 KB
144 KB View Download