New issue
Advanced search Search tips

Issue 684661 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Make VrMetricsHelper tab-aware and allow tracking multiple tabs(?).

Project Member Reported by mthiesse@chromium.org, Jan 24 2017

Issue description

VrMetricsHelper tracks only the main web contents, and it's unclear how it should behave when switching tabs. Should it drop existing stats and just switch? Should it hold observers for multiple at once and track them separately?
 

Comment 1 by amp@chromium.org, Jan 24 2017

Just adding some thoughts after looking at this from the related code review.

IIRC metrics are handled on the basis of a session which has a timeout.  If you come back to vr after having done something else for a while it should create a new session.

Ideally a session does include navigation across multiple sites and tabs as long as the user is still actively engaged so this does sound like something we should do, but I think it only needs to include what the user actually focuses on (ie if the user has 20 tabs open we don't need to create an observer on all of them until they actually switch to them in vr).

I think the metrics helper could probably track multiple web contents and maybe drop older web contents after some timeout similar to how it ends sessions now.

Bill will have more context on what works best here though, and I'm not sure if the above suggestion ends up being problematic in some way.
Blocking: 706436

Comment 3 by tiborg@chromium.org, May 10 2017

Blocking: -706436
Removing issue 706436 as blocked on this since the v0 browser does not support tab switching from within VR.
Labels: -VR-DF
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -ddorwin@chromium.org tiborg@chromium.org
Labels: -Hotlist-Recharge-Cold -Proj-VR-Shell -VR-TD
Status: Available (was: Untriaged)
 Issue 817559 , which affects native pages, may be related.
Labels: VR-metrics
Labels: -Type-Bug VRB-Tabs Type-Task
Status: Archived (was: Available)

Comment 9 by samdrazin@chromium.org, Jan 18 (5 days ago)

Labels: -VRB-Tabs VR-B-Tabs

Sign in to add a comment