$i18n{greetingHeader} appears in the OOBE flow |
|||||||||||||||||||
Issue description
Chrome Version: 57.0.2984.4
OS: Chrome OS
What steps will reproduce the problem?
(1) begin OOBE flow
I see $i18n{greetingHeader} render on my screen in the OOBE flow.
Sounds like this is a bug in the new template system from 677338.
See feedback report and screenshot here: https://feedback.corp.google.com/#/Report/51969988157
I am running 9199.1.0 branch on our new Apollo Lake devices.
,
Jan 25 2017
Reverting the change that I believe caused this. (https://codereview.chromium.org/2653123003/)
,
Jan 30 2017
This still happens on the M-57 branch, as of 9202.9. Can you help please pick this back for 57?
,
Jan 30 2017
,
Jan 30 2017
+ketakid.
,
Jan 31 2017
Approving merge to M57 Chrome OS.
,
Feb 6 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 6 2017
I used drover to merge the patch. I rarely do this kind of patch (this might be the second time). If it's not correctly patched, please let me know so that I can learn and correct it. (If it doesn't look fixed, then I would suspect that it's not correctly patched since the fix should be solid).
,
Feb 9 2017
,
Feb 9 2017
Your CL does not appear to be in branch. This is still broken.
,
Feb 9 2017
,
Feb 9 2017
alemate@ can you please help dschuyler@ drover this change asap?
,
Feb 9 2017
alemate@/dschuyler@ - please merge the fix soonest possible. moving to stable.
,
Feb 9 2017
,
Feb 9 2017
Requesting merge.
,
Feb 9 2017
Requesting merge for https://codereview.chromium.org/2653123003 .
,
Feb 9 2017
,
Feb 9 2017
Dave landed fix in https://codereview.chromium.org/2681863006 . Closing this.
,
Feb 14 2017
,
Mar 3 2017
9202.43.0 / 57.0.2987.85 beta-channel
,
Mar 3 2017
,
Mar 3 2017
,
Apr 27 2017
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by hennessywill@chromium.org
, Jan 24 2017299 KB
299 KB Download
84.0 KB
84.0 KB View Download