New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684652 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Text in unsuccessful download notification has multiple issues

Project Member Reported by derat@chromium.org, Jan 24 2017

Issue description

Google Chrome	55.0.2883.105 (Official Build) (64-bit)
Platform	8872.76.0 (Official Build) stable-channel panther

A download failed because I ran out of disk space. There's a weird extra ellipsis inserted at the end of the notification's text, and the whole thing seems ungrammatical:

"6.3/7.2 GB, Failed - Your hard disk is full.
Please save to another location or make more room on the hard disk...."

- Why's there a comma? A colon may be more appropriate.
- Does the "Failed" string actually add anything?
- Where's the ellipsis (resulting in four periods after the sentence) coming from? IDS_DOWNLOAD_INTERRUPTED_DESCRIPTION_DISK_FULL doesn't have an ellipsis on the end. Is it being added somewhere to indicate that a new window will be opened?
 
Screenshot 2017-01-24 at 10.34.59.png
47.2 KB View Download
Labels: -M-55 M-58
Owner: sgabr...@chromium.org
Status: Assigned (was: Untriaged)
sgabriel@ could take a look at what this text should say (or reroute appropriately)?
Cc: jennschen@chromium.org
Thanks for catching that.
We should remove ",FAILED" you are right, it doesn't add anything, status is reported in title.
We should remove ellipsis.

Adding Jenn just for visibility/sanity check. Seems like an easy fix for me.
Owner: zalcorn@chromium.org
Status: Untriaged (was: Assigned)
This is a gnarly string for sure, would be good to rework. 

Please check with Lindsay for string advice — we may be able to leverage something existing here. 
Status: Assigned (was: Untriaged)
Lindsay is taking a look at the string.
From our copy writer:

[Title] Can’t download file [Title]
[Content] There isn’t enough space to download <download name>. Save file to another location or free up disk space. [Content]



Comment 8 by derat@chromium.org, Feb 15 2017

nit: "Save it to another location ..." or "Choose another location ..." to keep things grammatical without making the string longer?
Cc: zalcorn@chromium.org
Owner: weifangsun@chromium.org
Weifang, who's the right person to fix this (seems files app adjacent).
Cc: weifangsun@chromium.org
Owner: fukino@chromium.org
@fukino - Can you confirm if this notification is owned by the Files App team? If so, could you help to assign to the right owner? Thanks!

Sign in to add a comment