New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684636 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 684642



Sign in to add a comment

[Media Router] Define MediaRouteController + MediaStatusObserver Mojo APIs

Project Member Reported by imch...@chromium.org, Jan 24 2017

Issue description

Define APIs for initializing MediaRouteControllers and registering media status observers.
 
Blocking: 684642

Comment 2 by sko...@chromium.org, Jan 26 2017

Status: Available (was: Untriaged)
Owner: taku...@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7

commit 67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7
Author: takumif <takumif@chromium.org>
Date: Wed Mar 22 23:14:53 2017

[Media Router] Custom Controls 1 - Add MediaStatus, MediaRouteController, and
mojo interfaces

This CL adds MediaRouteController that will forward media controller commands
from the custom controls WebUI to the Media Router component extension, and
will receive MediaStatus updates from the extension which it then will forward
to its Observer(s) (= to the WebUI).

This patch includes mojo interfaces/structs that were first reviewed in this
patch [1]. The MediaController mojo interface will be implemented in the
component extension (not a part of Chromium), and will receive commands from
MediaRouteController. MediaRouteController implements the MediaStatusObserver
mojo interface and receives updates from the extension. Typemapping between
media_router::mojom::MediaStatus and media_router::MediaStatus is also
included in this CL.

Changes in extensions/renderer/ are for exposing the new mojo interfaces to
the component extension.

The Chromium-side implementation of custom controls redesign will be done in
these patches:
1. Mojo/MediaStatus/MediaRouteController:     this patch
2. MediaRouter::GetRouteController():         http://crrev/2728543009
3. MRUI/MRWebUIMessageHandler:                http://crrev/2731033002
4. Custom controls WebUI:                     http://crrev/2725503002

Custom controls redesign design doc:
https://docs.google.com/document/d/1_8QxdFIiiJX39jR1Wi1Zn9FW-Y66EMvX1GmQZvjN4G0/edit

[1] https://codereview.chromium.org/2674363002/

BUG= 684636 , 684635 

Review-Url: https://codereview.chromium.org/2727123002
Cr-Commit-Position: refs/heads/master@{#458922}

[modify] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/BUILD.gn
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/media_status.cc
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/media_status.h
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/mojo/media_controller.mojom
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/mojo/media_route_controller.cc
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/mojo/media_route_controller.h
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/mojo/media_route_controller_unittest.cc
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/mojo/media_status.mojom
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/mojo/media_status.typemap
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/mojo/media_status_struct_traits.cc
[add] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/mojo/media_status_struct_traits.h
[modify] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/browser/media/router/mojo/typemaps.gni
[modify] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/chrome/test/BUILD.gn
[modify] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/67a8f64435d0a1c3ae9d04e33f965f885b9cb8b7/extensions/renderer/resources/extensions_renderer_resources.grd

Description: Show this description
Status: Fixed (was: Started)
Status: Started (was: Fixed)
Keeping this open until the second patch [1] lands.

https://codereview.chromium.org/2728543009/
Status: Fixed (was: Started)
Closing, as the patch above has landed.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcc92ee77b05de4fec004c3d1b78366ab6f6c350

commit bcc92ee77b05de4fec004c3d1b78366ab6f6c350
Author: takumif <takumif@chromium.org>
Date: Tue Apr 25 18:13:13 2017

[Media Router] Merge createMediaRouteController and setMediaRouteStatusObserver
in bindings

We merged the methods createMediaRouteController and setMediaRouteStatusObserver
in the MediaRouteProvider mojo interface in this CL [1]. This patch applies that
change to media_router_bindings.js.

[1] https://codereview.chromium.org/2728543009/

BUG= 684636 

Review-Url: https://codereview.chromium.org/2834603004
Cr-Commit-Position: refs/heads/master@{#467049}

[modify] https://crrev.com/bcc92ee77b05de4fec004c3d1b78366ab6f6c350/chrome/renderer/resources/extensions/media_router_bindings.js

Sign in to add a comment