New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684633 link

Starred by 2 users
Status: Fixed
Owner:
taku...@chromium.org
Closed: Jun 2017
Cc:
mfo...@chromium.org
█ imch...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 684642



Sign in to add a comment

[Media Router UI] Migrate custom controller templates into Chromium

Project Member Reported by imch...@chromium.org, Jan 24 2017 
These templates are currently in the MR extension. We will need to migrate them into Chromium in order to remove the dependency on <extensionview>.

Modifications will be necessary to replace the Presentation API (or Cast SDK for Cast template) logic for commands with standardized commands sent via MediaRouterUI.

This work is not necessarily blocked by having the media controller API / implementation available in MR, as we can stub out the calls in MediaRouterUI.

Comment 1 by imch...@chromium.org, Jan 24 2017

Blocking: 684642

Comment 2 by imch...@chromium.org, Jan 24 2017

Components: -Blink>PresentationAPI Internals>Cast>UI

Comment 3 by sko...@chromium.org, Jan 26 2017

Status: Assigned (was: Untriaged)

Comment 4 by taku...@chromium.org, Feb 14 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f7923888b023461435906b4b1488a5a857cdc32

commit 3f7923888b023461435906b4b1488a5a857cdc32
Author: takumif <takumif@chromium.org>
Date: Tue May 30 20:58:56 2017

[Media Router] Custom Controls 4 - Implement details view WebUI

This CL adds a built-in alternative to the extensionview controller in the route
details view of the media router dialog WebUI. The WebUI route controller is
functionally equivalent to the extensionview controller.

Whenever the WebUI is notified by the browser process of updates to the media
status of the shown route, the details view is updated. Whenever the user
interacts with the media controls on the details view, the media commands are
sent to the browser process.

The switch to the WebUI controller is managed by a Finch experiment that is
currently disabled, so this CL has no behavioral change. Its functionality can
be checked out with the flag --enable-features=MediaRouterUIRouteController.

Before-and-after screenshots:
https://docs.google.com/document/d/1v8jGV33FiFtH_qs2_Ui0UNubt1nHRN_CBrHLt1wRXF0

The Chromium-side implementation of custom controls will be done in these
patches:
1. Mojo/MediaStatus/MediaRouteController:     http://crrev/2727123002
2. MediaRouter::GetRouteController():         http://crrev/2728543009
3. MRUI/MRWebUIMessageHandler:                http://crrev/2731033002
4. Custom controls WebUI:                     this patch

Custom controls design doc:
https://docs.google.com/document/d/1_8QxdFIiiJX39jR1Wi1Zn9FW-Y66EMvX1GmQZvjN4G0/edit

[1] https://codereview.chromium.org/2724513002/

BUG= 684633 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2725503002
Cr-Commit-Position: refs/heads/master@{#475667}

[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/media_router_resources.grdp
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/compiled_resources2.gyp
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/media_router_container/compiled_resources2.gyp
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/media_router_container/media_router_container_interface.js
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_controls/compiled_resources2.gyp
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_controls/route_controls.css
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_controls/route_controls.html
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_controls/route_controls_interface.js
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_details/compiled_resources2.gyp
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_details/extension_view_wrapper/compiled_resources2.gyp
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_details/extension_view_wrapper/extension_view_wrapper.css
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_details/extension_view_wrapper/extension_view_wrapper.html
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_details/extension_view_wrapper/extension_view_wrapper.js
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_details/route_details.css
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/media_router.css
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/media_router.html
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/media_router.js
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/media_router_browser_api.js
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/media_router_common.css
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/resources/media_router/media_router_ui_interface.js
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/ui/webui/media_router/media_router_resources_provider.cc
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/test/data/webui/media_router/media_router_container_route_tests.js
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/test/data/webui/media_router/media_router_elements_browsertest.js
[add] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/test/data/webui/media_router/route_controls_tests.js
[modify] https://crrev.com/3f7923888b023461435906b4b1488a5a857cdc32/chrome/test/data/webui/media_router/route_details_tests.js

Comment 6 by taku...@chromium.org, Jun 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment