New issue
Advanced search Search tips

Issue 684627 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 23
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 624175



Sign in to add a comment

make app list shadows match rest of (new) cros shadows

Project Member Reported by est...@chromium.org, Jan 24 2017

Issue description

the app list is the last user of ShadowBorder and also has this[1] which is essentially redundant with [2] ("elevation" and "z" being the same concept)

[1] https://cs.chromium.org/chromium/src/ui/app_list/app_list_constants.cc?rcl=1485260312&l=151
[2] https://cs.chromium.org/chromium/src/ui/gfx/shadow_util.cc?rcl=0&l=84
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ef3c96947ed010f07e1134c633b5761050fdf33

commit 9ef3c96947ed010f07e1134c633b5761050fdf33
Author: estade <estade@chromium.org>
Date: Thu Mar 09 05:16:59 2017

Update last few users of deprecated CreateShadowDrawLooper and remove
it.

As a general rule, doubling the blur values passed in will yield nearly
identical visuals. The main difference is that ShadowValues::GetMargins()
will now return the correct value because of the corrected blur values.
For example, ShadowBorder will now set the correct margins. Previous to
this change, the ShadowBorders in the AppList were clipped because of
the incorrect margins.

BUG= 684627 , 624175 
TBR=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2733363002
Cr-Commit-Position: refs/heads/master@{#455672}

[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ash/common/system/tray/tray_details_view.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ash/magnifier/partial_magnification_controller.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/chrome/browser/ui/views/message_center/message_center_frame_view.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/content/browser/web_contents/aura/gesture_nav_simple.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ui/gfx/image/image_skia_operations.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ui/gfx/render_text.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ui/gfx/shadow_util.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ui/gfx/skia_paint_util.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ui/gfx/skia_paint_util.h
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ui/views/animation/ink_drop_painted_layer_delegates.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ui/views/bubble/bubble_border.cc
[modify] https://crrev.com/9ef3c96947ed010f07e1134c633b5761050fdf33/ui/views/controls/button/toggle_button.cc

Status: Archived (was: Assigned)

Sign in to add a comment