Settings test fail in landscape mode for 5s |
||
Issue descriptionSettings test fail in landscape mode for 5s, but they really shouldn't since we use the "usingSearchAction" for our scroll actions in openSubSettings method where usingSearchAction should continue to scroll down iteratively by the kScrollDisplacement until it finds the matcher or until it reaches the bottom. Currently, watching the tests we can see this doesn't scroll all the way to the bottom. ios/chrome/browser/ui/settings/settings_eg_test.mm I'm adding this TODO as part of the review for https://codereview.chromium.org/2643303005
,
Sep 14 2017
TODO(684619) was removed. Is there anything else needs to be done here? If so, could you please specify which test was failing.
,
Sep 14 2017
I think this needs an investigation to make sure it's fixed. We should really have a test that runs all of our tests on these small screens to find any UI bugs. We have a bug for that, so I think we can use that to track this one. Closing as fixed (some fixes were in crbug.com/717163 ). crbug.com/717548 contains the bug to track getting automation running for small, landscape devices. |
||
►
Sign in to add a comment |
||
Comment 1 by baxley@chromium.org
, Jan 24 2017Components: -Test Test>iOS
Labels: -Restrict-View-Google