New issue
Advanced search Search tips

Issue 684613 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Payments] Credit card text should not be disabled when missing info

Project Member Reported by ma...@chromium.org, Jan 24 2017

Issue description

See attached screenshot.

Consensus seems to be that the Visa .... 1111 shouldn't be disabled.


 
Screenshot_20170124-115345.png
135 KB View Download

Comment 1 by zkoch@chromium.org, Jan 24 2017

Labels: -Pri-2 M-57 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac8115d65b026823fc338ca7f9afd8412fa20b81

commit ac8115d65b026823fc338ca7f9afd8412fa20b81
Author: gogerald <gogerald@chromium.org>
Date: Tue Jan 24 22:29:24 2017

Rename function to avoid unintentional override

isValid in AutofillPaymentInstrument overrides isValid in PaymentOption unintentionally,

BUG= 684613 

Review-Url: https://codereview.chromium.org/2652063002
Cr-Commit-Position: refs/heads/master@{#445842}

[modify] https://crrev.com/ac8115d65b026823fc338ca7f9afd8412fa20b81/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/ac8115d65b026823fc338ca7f9afd8412fa20b81/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 24 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 25 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/404743c535686b18dc35a62892a2481c72bce589

commit 404743c535686b18dc35a62892a2481c72bce589
Author: gogerald <gogerald@google.com>
Date: Wed Jan 25 14:49:14 2017

Rename function to avoid unintentional override

isValid in AutofillPaymentInstrument overrides isValid in PaymentOption unintentionally,

BUG= 684613 

Review-Url: https://codereview.chromium.org/2652063002
Cr-Commit-Position: refs/heads/master@{#445842}
(cherry picked from commit ac8115d65b026823fc338ca7f9afd8412fa20b81)

Review-Url: https://codereview.chromium.org/2658463003 .
Cr-Commit-Position: refs/branch-heads/2987@{#85}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/404743c535686b18dc35a62892a2481c72bce589/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/404743c535686b18dc35a62892a2481c72bce589/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Comment 6 by ma...@chromium.org, Jan 25 2017

Thanks for the quick turnaround!
Status: Fixed (was: Assigned)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment