Warn or fail a build if a file in an excluded directory is required by runtime_deps |
||||
Issue descriptionThis originally manifested as bug 684406 , which was first seen after landing https://codereview.chromium.org/2645973006. That CL has since been reverted, but when applied we see this error on some Android bots: OSError: [Errno 2] No such file or directory: '/b/c/b/Android_Tests__dbg___L_Nexus9_/src/out/Debug/gen/services/service_manager/manifest.json' This can be seen for example on the content_browsertests step as a result of some work catapult is doing. Clearly it has some expectation that this file is on the test device -- which is unsurprising since that file is in the runtime_deps of content_browsertests -- but the file was never copied to the device.
,
Jan 24 2017
gen/ does not get transferred between builder and tester on any platform (https://codesearch.chromium.org/chromium/build/scripts/common/chromium_utils.py?rcl=0&l=1871). If you need a file to be available at runtime, you'll need to put it in another directory.
,
Jan 24 2017
Makes sense. Perhaps then we should raise some kind of error about this at build time if a gen/ file is in a target's runtime_deps.
,
Jan 24 2017
Not a bad idea. Repurposing this bug.
,
Jan 24 2017
I'm not sure we can easily do that without layering violations. I kinda suspect the problem here is more that the archive script is being too aggressive.
,
Jan 25 2017
A similar error with another missing file showed up on the same bots today: OSError: [Errno 2] No such file or directory: '/b/c/b/Android_Tests__dbg___K_Nexus5_/src/out/Debug/gen/services/shape_detection/manifest.json' (https://build.chromium.org/p/chromium.webrtc.fyi/console, https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20(dbg)%20(K%20Nexus5) )
,
Jan 25 2017
It's a collision with another CL that landed. I'll fix it.
,
Feb 12 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||
►
Sign in to add a comment |
||||
Comment 1 by jbudorick@chromium.org
, Jan 24 2017Labels: -Pri-2 OS-Android Pri-1
Owner: jbudorick@chromium.org
Status: Assigned (was: Untriaged)