Chrome Custom Tabs show up under Recent Tabs suggestions |
||||||
Issue descriptionSteps to reproduce: 1) Enable RECENT_TABS suggestions on the NTP 2) Open a Chrome Custom Tab 3) Switch back to the main Chrome activity and open the NTP 4) Tap on the suggestion for the opened custom tab Expected: Either the custom tab should open, or the suggestion shouldn't appear. Actual: Nothing happens when tapping on the suggestion. Presumably this is because the tab is not part of the default tab model, so we can't switch to it by just setting an index on the tab model.
,
Jan 25 2017
I think by now any external browsing intent (i.e. opening a link from any other app) should be opened using custom tabs. If that doesn't work, there is a demo app to open custom tabs at https://github.com/GoogleChrome/custom-tabs-client.
,
Jan 25 2017
Potentially need to make Recent Tab Helper aware about the fact that the tab is CCT and not make a snapshot in this case.
,
Jan 25 2017
,
Jan 26 2017
Actually, it might be nice to take snapshots of custom tabs too. In addition, you can move a CCT into Chrome, so at that point it would almost be strange to not have a snapshot.
,
Jan 26 2017
When we move them into Chrome, they are removed from the old tab model and added to the tab model for TabbedActivity, so during that process, you may already be taking another snapshot perhaps? For testing with custom tabs, you can build the target custom_tabs_client_example_apk and install CustomTabsClient.apk on the device to launch them with different setup options.
,
Feb 3 2017
,
Aug 9 2017
Canceled as noted in issue 659205. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vitaliii@chromium.org
, Jan 24 2017