New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684591 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: pasting Powerpoint slides / Excel images show up as files but without data

Reported by s...@benchling.com, Jan 24 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36

Steps to reproduce the problem:
1. Open Presentation1.pptx, select the slide, and copy to clipboard (see powerpoint-repro.png for a screenshot)

2. Open editor.html, paste into the contentEditable. 

3. Open Workbook1.xlsx , select the image, and copy to clipboard (see excel-repro.png for a screenshot)

4. Switch to editor.html, paste into the contentEditable.

5. Optionally (as a contro)l: use keyboard shortcut Ctrl-Cmd-Shift-3 to put a screenshot on the clipboard, and then paste into editor.html.

What is the expected behavior?
We expect to see outputted 3 times:

```
types found: Files
"Files" type exists: true
File item:  [object DataTransferItem]
File contents: [object Blob]
```

What went wrong?
We see outputted twice (once for Powerpoint and Excel):
```
types found: Files
"Files" type exists: true
File item:  [object DataTransferItem]
File contents: null
```

and the expected output for the control.

chrome-54.log shows that this used to work correctly.
chrome-55.log shows that this was a regression.

Did this work before? Yes Chrome 54.0.2840.71

Does this work in other browsers? N/A

Chrome version: 54.0.2840.71  Channel: n/a
OS Version: OS X 10.10.5
Flash Version: Shockwave Flash 24.0 r0
 
Archive.zip
404 KB Download

Comment 1 by s...@benchling.com, Jan 24 2017

Archive.zip also contains a folder called "powerpoint clipboard data" that shows all of the data that was found on the clipboard via the ClipboardViewer tool found here:  https://developer.apple.com/library/content/samplecode/ClipboardViewer/Introduction/Intro.html 


(Also note: I accidentally filed this with Chrome 54 open, but rest assured, I have confirmed that this is a regression in Chrome 55)

Comment 2 by ajha@chromium.org, Jan 25 2017

Labels: Needs-Bisect Needs-Milestone
Labels: Needs-Triage-M58

Comment 4 by pwnall@chromium.org, Jan 26 2017

Labels: -Needs-Bisect -Needs-Milestone -Needs-Triage-M58 Needs-Feedback
I was able to reproduce this in M56 (Beta) on OSX 10.12.3 with MS Powerpoint and Excel 15.27. The output says "File contents: " (there is nothing past the colon).

However, I was not able to reproduce on 58.0.2992.0 (canary). The output matches the "expected output" section. Can you please check to see if Canary works for you?

Comment 5 by s...@benchling.com, Jan 27 2017

@pwnall: Confirmed that 58.0.2994.0 works with Powerpoint / Excel 15.28

Comment 6 by s...@benchling.com, Jan 27 2017

Confirmed that the bug still exists in 56.0.2924.76. Is there an (easy) way for me to test if this is fixed in 57?

If the bug isn't fixed in 57, is it possible to get this backported from 58 to 57? We have many users that work with Office files and copy / paste the data into our web-based document editor. The workaround is very cumbersome, either taking a screenshot of what would be copied or exporting the file and then importing it as a file.




Comment 7 by s...@benchling.com, Jan 27 2017

(Figured out that the dev channel is on Chrome 57)

Tested on 57.0.2987.13 and the bug is also fixed. As I understand it, 57 will be stable in 6 weeks? Would it be possible to backport the fix to Chrome 56?
pwnall@ - As per comment #7, it seems that the issue have been fixed in M-57.

Could you please let us know if reverse bisect is required for this issue?

Thanks...!!

Comment 9 by ajha@chromium.org, Jan 31 2017

Labels: Needs-Bisect M-56
Tagging with M-56 label to identify the root cause that fixed this as this is fixed in M-58 and M-57. 
Project Member

Comment 10 by sheriffbot@chromium.org, Feb 7 2017

Labels: -Needs-Feedback Needs-Review
Owner: pwnall@chromium.org
Thank you for providing more feedback. Adding requester "pwnall@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: pwnall@chromium.org
Owner: krajshree@chromium.org
Status: Assigned (was: Unconfirmed)
#7: How hard would it be to get your users on the Beta channel until M57 hits stable? The bar for merging something into stable is pretty high.

#8: Yes, please! Let's reverse bisect, so I can assess the difficulty of merging. I assigned the bug to you for tracking, please assign it back to me once the reverse bisect result is available.

Comment 12 by s...@benchling.com, Feb 10 2017

pwnall@ - It isn't too feasible to do that across the board. Many of our customers' IT departments restrict installation of software.

Thanks for looking into this!
#12: Just to manage expectations -- it is quite unlikely that a fix would get merged into stable for this issue. I won't know for sure until I see the reverse bisect result, but you should plan assuming that M56 will continue to behave like it currently does.
Labels: -Needs-Review
Cleaning up sheriffbot label "Needs-Review" label as a part of modified "Needs-Feedback" sheriffbot rule. [ref bug for cleanup 684919]
pwnall@, M57 hit stable and I've confirmed that this is no longer an issue.
Status: Fixed (was: Assigned)
#15: Thank you very much for the feedback!

Sign in to add a comment