ClangMacToT build broken by clang r292518 which limits uses of injected class name in nested name specifiers |
|||
Issue descriptionBuild: https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac%20%28dbg%29/builds/7763 https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac%20%28dbg%29/builds/7763/steps/compile/logs/stdio Message: FAILED: obj/net/net/x509_certificate_mac.o ... ../../net/cert/x509_certificate_mac.cc:79:19: error: qualified reference to 'Time' is a constructor name rather than a type in this context *result = Time::Time(); ^ Richard implemented DR1310 (http://wg21.link/cwg1310), which I think means you can't find the injected class name in an NNS like this. We'll need to do a cleanup before the next roll.
,
Jan 24 2017
This doesn't look too bad. With https://codereview.chromium.org/2652763008/, which fixes the case above, I can build the chrome target. Trying the rest now.
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07a0b4579f2dcae5f9d02d5b78fc3b8f79bf1f6d commit 07a0b4579f2dcae5f9d02d5b78fc3b8f79bf1f6d Author: hans <hans@chromium.org> Date: Tue Jan 24 22:22:24 2017 Fix constructor call The expression was referring directly to the constructor, but it needs to refer to the type. New versions of Clang started erroring on this (see bug). BUG= 684590 Review-Url: https://codereview.chromium.org/2652763008 Cr-Commit-Position: refs/heads/master@{#445839} [modify] https://crrev.com/07a0b4579f2dcae5f9d02d5b78fc3b8f79bf1f6d/net/cert/x509_certificate_mac.cc
,
Jan 24 2017
Building "all" in mac release build works too. Closing unless more of it shows up on the bots.
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/873a0b98cbf3a3e6aa5f2b0cc2f1138257fdf21b commit 873a0b98cbf3a3e6aa5f2b0cc2f1138257fdf21b Author: thakis <thakis@chromium.org> Date: Thu Jan 26 19:39:11 2017 ios: Fix constructor call The expression was referring directly to the constructor, but it needs to refer to the type. New versions of Clang started erroring on this (see bug). BUG= 684590 Review-Url: https://codereview.chromium.org/2654363002 Cr-Commit-Position: refs/heads/master@{#446397} [modify] https://crrev.com/873a0b98cbf3a3e6aa5f2b0cc2f1138257fdf21b/ios/chrome/browser/tabs/tab.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by h...@chromium.org
, Jan 24 2017