New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684586 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Features blacklisted on Android devices with PowerVR GPU

Issue description

Steps to reproduce the problem:
1. Use an Android device containing a PowerVR Rogue GPU
2. Open Chrome
3. Go go chrome://gpu
4. Notice device features "accelerated_2d_canvas" and "gpu_rasterization" are disabled

What is the expected behavior?
These features should be enabled by default (on devices with an up to date GPU Driver)

What went wrong?
It seems like these features were disabled quite a while ago in the file chromium/src/gpu/config/software_rendering_list_json.cc (id 104).

To ensure whatever bug that originally caused the blacklisting does not re-appear, we suggest the blacklist is only updated for current and future versions of the GPU driver (leaving legacy devices blacklisted). A patch of the suggested change is attached.

Our testing has not revealed any issues with the latest 1.8 driver running with these features enabled.

Did this work before? Yes 

Chrome version: 55.0.2883.91  Channel: stable
OS Version: Android Nougat (7.0)
Flash Version: Shockwave Flash 24.0 r0
 
software_renderer_list_Rogue_DDK_Version.json.cc (1).diff
438 bytes Download
Cc: aelias@chromium.org boliu@chromium.org piman@chromium.org
Components: Internals>GPU>Canvas2D Internals>GPU>Rasterization Internals>GPU
Owner: piman@chromium.org
Status: Assigned (was: Unconfirmed)
Ian - please upload your patch to reitveld if you can (https://www.chromium.org/developers/contributing-code).

The relevant entry for PowerVR Rogue is:

     {
      "id": 104,
      "description": "GPU raster broken on PowerVR Rogue",
      "cr_bugs": [436331, 483574],
      "os": {
        "type": "android"
      },
      "gl_renderer": "PowerVR Rogue.*",
      "features": [
        "accelerated_2d_canvas",
        "gpu_rasterization"
      ]
    },

This links to two issues from the Android L timeframe:
 issue 436331  - [LG-F490L(liger)] rasterization issue(crash) (Nov 2014)
 issue 483574  - Expand gpu raster blacklist to all PowerVR Rogue devices (May 2015)

Comment 2 by boliu@chromium.org, Jan 24 2017

> Our testing has not revealed any issues with the latest 1.8 driver running with these features enabled.

what kind of testing did you do?

What device has 1.8 driver right now?
Hi,

Currently I am not set up to submit the code to the Chromium project.

There are no devices available publicly yet with 1.8 drivers installed. We recommended this change to be made from 1.8 onwards to be sure that we don't break any older devices that are already available. 

If you wanted to do testing to confirm theses features work correctly, you could use an Acer Chromebook R13 (elm) which uses our 1.6 driver and does not show any issues with these features un-blacklisted.

Thanks,
Ian

Comment 4 by boliu@chromium.org, Feb 9 2017

the entry is limited to os type android though. any android devices with new driver?

Comment 5 by piman@chromium.org, May 10 2017

Owner: boliu@chromium.org
->Bo who was tracking the original failures

Comment 6 by boliu@chromium.org, May 10 2017

Labels: -Pri-2 Pri-3
> To ensure whatever bug that originally caused the blacklisting does not re-appear, we suggest the blacklist is only updated for current and future versions of the GPU driver (leaving legacy devices blacklisted).

 crbug.com/483574  is specifically a synchronization/deadlock issue in webview, so need to test that on android specifically. So really do need to test on a recent 
popular android device, even if it's not the latest driver. So I'd be cautious with relaxing blacklists

Doing a bit of googling and looking through the list of android devices at and, I didn't find any recent android devices with "powervr rogue" gpu, although honestly, I'm not sure which powervr gpus have the "rogue" moniker.
Sorry for the long delay here. One suggestion for a device you could use for retesting this would be the Meizu PRO 7 Plus. Just ensure it has the MediaTek Helio X30 SoC which contains a PowerVR Rogue GPU with recent drivers.

Thanks

Comment 8 by boliu@chromium.org, Oct 17 2017

Owner: candr...@chromium.org
+candrada: can we buy that device? Meizu PRO 7 Plus
I have this on order.
We received this order.

Comment 11 by boliu@chromium.org, Oct 24 2017

Owner: boliu@chromium.org
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd22f25294a4c04e673b4e7da20a33b10449e9bb

commit bd22f25294a4c04e673b4e7da20a33b10449e9bb
Author: Bo Liu <boliu@chromium.org>
Date: Tue Nov 07 22:31:06 2017

gpu: Limit PowerVR blacklist to < 1.8

Obtained a device with IMG PowerVR version 1.8 drivers, and looks like
gpu raster and canvas work fine. Tried to reproduce the same bugs that
got the blacklisted added in the first place, and could not reproduce.

Bug:  684586 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I344abeebceec09ea1d3525f8880fa3d2bb812dc1
Reviewed-on: https://chromium-review.googlesource.com/756883
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514625}
[modify] https://crrev.com/bd22f25294a4c04e673b4e7da20a33b10449e9bb/gpu/config/software_rendering_list.json

Status: Fixed (was: Assigned)

Sign in to add a comment