New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684553 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Timeout in skia_pathop_fuzzer

Project Member Reported by ClusterFuzz, Jan 24 2017

Issue description

Components: Internals>Skia
Labels: Test-Predator-Wrong

Comment 2 by hcm@chromium.org, Mar 6 2017

cannot access the report here

Comment 3 by hcm@chromium.org, Mar 6 2017

nm just got it w/ my chromium

Comment 4 by hcm@chromium.org, Mar 6 2017

Cc: caryclark@google.com
Owner: kjlubick@google.com
Over to Kevin, Cary...

Comment 5 by hcm@chromium.org, Mar 6 2017

Status: Assigned (was: Untriaged)
Cc: -caryclark@google.com kjlubick@google.com
Owner: caryclark@google.com
Steps to repro (in *chromium* checkout):
gn gen out/libfuzzer '--args=is_debug=false use_libfuzzer=true is_ubsan_security=true enable_nacl=false proprietary_codecs=true ffmpeg_branding="ChromeOS"'
ninja -C out/libfuzzer skia_pathop_fuzzer
timeout 5 out/libfuzzer/skia_pathop_fuzzer ~/Downloads/clusterfuzz-testcase-6051591275937792 

Observe fuzzer does not return before 5s.  I let this go for over a minute, and it still didn't return.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/4eed4c885050132b7131324ea336ad0f6d977fef

commit 4eed4c885050132b7131324ea336ad0f6d977fef
Author: Cary Clark <caryclark@skia.org>
Date: Thu Mar 09 14:11:11 2017

limit addEndMoveSpans loop in pathops

Prevent addEndMoveSpans from looping
forever and abort with an error
if the loop count is crazy big.

R=kjlubick@google.com
BUG= 684553 

Change-Id: I16c250c0b2f88534f809aba17a18081aea4e1f44
Reviewed-on: https://skia-review.googlesource.com/9458
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Cary Clark <caryclark@google.com>

[modify] https://crrev.com/4eed4c885050132b7131324ea336ad0f6d977fef/tests/PathOpsOpTest.cpp
[modify] https://crrev.com/4eed4c885050132b7131324ea336ad0f6d977fef/src/pathops/SkOpCoincidence.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aa57ebd97f6f68fdbf29d44588af7b32a13c249

commit 1aa57ebd97f6f68fdbf29d44588af7b32a13c249
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Thu Mar 09 16:06:41 2017

Roll src/third_party/skia/ 08541e8d7..c65aec976 (2 commits)

https://skia.googlesource.com/skia.git/+log/08541e8d7f28..c65aec976196

$ git log 08541e8d7..c65aec976 --date=short --no-merges --format='%ad %ae %s'
2017-03-09 bsalomon Make GrClip.h private
2017-03-08 caryclark limit addEndMoveSpans loop in pathops

Created with:
  roll-dep src/third_party/skia
BUG= 684553 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I8fb788b1ad19d487930809d3dda039660584d4ee
Reviewed-on: https://chromium-review.googlesource.com/451885
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455754}
[modify] https://crrev.com/1aa57ebd97f6f68fdbf29d44588af7b32a13c249/DEPS

Status: Fixed (was: Assigned)
Project Member

Comment 10 by ClusterFuzz, Mar 10 2017

Sign in to add a comment