New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684527 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug-Regression

Blocking:
issue 684067



Sign in to add a comment

cast_shell_linux is purple on most builds and blocks CQ

Project Member Reported by machenb...@chromium.org, Jan 24 2017

Issue description

Cc: mastiz@chromium.org rjwright@chromium.org manisca...@chromium.org moh...@chromium.org
CC chromium sheriffs
Owner: serg...@chromium.org
Status: Started (was: Untriaged)
Ack.
Owner: phajdan.jr@chromium.org
Looks like this have been caused by https://chromium-review.googlesource.com/c/430696. Pawel is looking into what's the best way to mitigate the outage.
Blocking: 684067
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6d01450c53cb93186d290a6977d0b0b513c2f2e7

commit 6d01450c53cb93186d290a6977d0b0b513c2f2e7
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Jan 24 14:41:43 2017

chromium_tests: raise an error on inconsistent swarming config

More specifically, fail builders which disable swarming on builder level,
but have tests in testing/buildbot that seem to enable swarming (but it's
still effectively disabled on builder level).

The goal of this CL is to catch all of current occurrences of this confusion
(which leads to build failures when swarming gets unexpectedly enabled
on these builders) and prevent regressions.

BUG= 684527 , 684067

Change-Id: Ibdcbaa1b8e0611c8e197110a75e953570b6b9dfd
Reviewed-on: https://chromium-review.googlesource.com/430682
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/6d01450c53cb93186d290a6977d0b0b513c2f2e7/scripts/slave/recipe_modules/chromium_tests/steps.py

Comment 6 by s...@chromium.org, Jan 24 2017

Cc: s...@chromium.org
Another page just arrived, which I also believe is related to this issue: OverallBuildInfraFailuresAlert. But it looks like the infra error rate is back to normal, probably due to fix landed in #5.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/50b55a83cf18402243080b0bc1d598ac1e76dc84

commit 50b55a83cf18402243080b0bc1d598ac1e76dc84
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Jan 24 15:58:57 2017

chromium_tests: use more accurate value for enable_swarming for generators

This solves an old TODO and is part of an effort to untangle enable_swarming.

TBR=maruel

BUG= 684573 ,  684527 

Change-Id: I2fb1a16abedbbc873c1b688bb437de5f5c99fc88
Reviewed-on: https://chromium-review.googlesource.com/431034
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json
[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json
[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder.json
[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder__dbg_.json
[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder.json
[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder__dbg_.json
[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder.json
[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder__dbg_.json
[modify] https://crrev.com/50b55a83cf18402243080b0bc1d598ac1e76dc84/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Builder_FYI.json

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36324125a1d77f4d720687be28f6751e7087cf8a

commit 36324125a1d77f4d720687be28f6751e7087cf8a
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Tue Jan 24 16:45:02 2017

Disable swarming for tests where it's disabled on builder level

This was detected using https://chromium-review.googlesource.com/c/430682/

BUG= 684527 , 684067
R=maruel@chromium.org

Review-Url: https://codereview.chromium.org/2649923009 .
Cr-Commit-Position: refs/heads/master@{#445742}

[modify] https://crrev.com/36324125a1d77f4d720687be28f6751e7087cf8a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/36324125a1d77f4d720687be28f6751e7087cf8a/testing/buildbot/chromium.linux.json

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/d59238c0ad1f3fad58377e634be62b3d5ac6137b

commit d59238c0ad1f3fad58377e634be62b3d5ac6137b
Author: Michael Case <mikecase@chromium.org>
Date: Tue Jan 24 17:09:44 2017

Revert "chromium_tests: use more accurate value for enable_swarming for generators"

This reverts commit 50b55a83cf18402243080b0bc1d598ac1e76dc84.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> chromium_tests: use more accurate value for enable_swarming for generators
> 
> This solves an old TODO and is part of an effort to untangle enable_swarming.
> 
> TBR=maruel
> 
> BUG= 684573 ,  684527 
> 
> Change-Id: I2fb1a16abedbbc873c1b688bb437de5f5c99fc88
> Reviewed-on: https://chromium-review.googlesource.com/431034
> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> 

TBR=maruel@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,mikecase@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 684573 ,  684527 

Change-Id: I2197a022d8c422b2c7316ff221db12f6086dd3cf
Reviewed-on: https://chromium-review.googlesource.com/431816
Commit-Queue: Michael Case <mikecase@chromium.org>
Reviewed-by: Michael Case <mikecase@chromium.org>

[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json
[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json
[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder.json
[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder__dbg_.json
[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder.json
[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder__dbg_.json
[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder.json
[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder__dbg_.json
[modify] https://crrev.com/d59238c0ad1f3fad58377e634be62b3d5ac6137b/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Builder_FYI.json

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3bcf05f962b5d1e43689937ae45165fe82534d33

commit 3bcf05f962b5d1e43689937ae45165fe82534d33
Author: Michael Case <mikecase@chromium.org>
Date: Tue Jan 24 17:14:32 2017

Revert "Revert "chromium_tests: use more accurate value for enable_swarming for generators""

This reverts commit d59238c0ad1f3fad58377e634be62b3d5ac6137b.

Reason for revert: Incorrectly reverted try to fix bots that had errors related to enable_swarming. Sorry :/

Original change's description:
> Revert "chromium_tests: use more accurate value for enable_swarming for generators"
> 
> This reverts commit 50b55a83cf18402243080b0bc1d598ac1e76dc84.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > chromium_tests: use more accurate value for enable_swarming for generators
> > 
> > This solves an old TODO and is part of an effort to untangle enable_swarming.
> > 
> > TBR=maruel
> > 
> > BUG= 684573 ,  684527 
> > 
> > Change-Id: I2fb1a16abedbbc873c1b688bb437de5f5c99fc88
> > Reviewed-on: https://chromium-review.googlesource.com/431034
> > Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> > 
> 
> TBR=maruel@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,mikecase@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 684573 ,  684527 
> 
> Change-Id: I2197a022d8c422b2c7316ff221db12f6086dd3cf
> Reviewed-on: https://chromium-review.googlesource.com/431816
> Commit-Queue: Michael Case <mikecase@chromium.org>
> Reviewed-by: Michael Case <mikecase@chromium.org>
> 

TBR=maruel@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,mikecase@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 684573 ,  684527 

Change-Id: I0ba05108d82372135431a71789f6f3dd855f304f
Reviewed-on: https://chromium-review.googlesource.com/431817
Commit-Queue: Michael Case <mikecase@chromium.org>
Reviewed-by: Michael Case <mikecase@chromium.org>

[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json
[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json
[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder.json
[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder__dbg_.json
[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder.json
[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder__dbg_.json
[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder.json
[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder__dbg_.json
[modify] https://crrev.com/3bcf05f962b5d1e43689937ae45165fe82534d33/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Builder_FYI.json

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/a8ae512113920921ea12d9dfabfe627fb099a0e6

commit a8ae512113920921ea12d9dfabfe627fb099a0e6
Author: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Date: Tue Jan 24 17:53:35 2017

Revert "chromium_tests: raise an error on inconsistent swarming config"

This reverts commit 6d01450c53cb93186d290a6977d0b0b513c2f2e7.

Reason for revert: It's safe, and now unnecessarily breaks bots. See https://goto.google.com/vtfuh .

Original change's description:
> chromium_tests: raise an error on inconsistent swarming config
> 
> More specifically, fail builders which disable swarming on builder level,
> but have tests in testing/buildbot that seem to enable swarming (but it's
> still effectively disabled on builder level).
> 
> The goal of this CL is to catch all of current occurrences of this confusion
> (which leads to build failures when swarming gets unexpectedly enabled
> on these builders) and prevent regressions.
> 
> BUG= 684527 , 684067
> 
> Change-Id: Ibdcbaa1b8e0611c8e197110a75e953570b6b9dfd
> Reviewed-on: https://chromium-review.googlesource.com/430682
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> 

TBR=maruel@chromium.org,phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 684527 , 684067

Change-Id: I32e03ea6318b06b00d381e1440dae2cfa5734c4c
Reviewed-on: https://chromium-review.googlesource.com/430683
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/a8ae512113920921ea12d9dfabfe627fb099a0e6/scripts/slave/recipe_modules/chromium_tests/steps.py

Note: Many V8 Chromium bots are now red with a swarming_sanity check that comes from one of the CLs here:
https://build.chromium.org/p/client.v8.fyi/console

Is this already resolved now? Also our chromium bot on the V8 CQ is blocked by this:
https://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/
Cc: phajdan.jr@chromium.org
Owner: ----
Status: Untriaged (was: Started)
Not sure if Pawel is still working on this. Making it available so that it goes to the next trooper and gets attention.

Please assign back to Pawel when bots have recovered.
Maybe the V8 problem is also resolved, just kicked off a manual build:
https://uberchromegw.corp.google.com/i/client.v8.fyi/builders/Linux%20Debug%20Builder/builds/4376
Owner: phajdan.jr@chromium.org
Status: Fixed (was: Untriaged)
Yes, this is fixed by above revert.
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4902f0922c2f1553486109786427de7a284b4cb

commit c4902f0922c2f1553486109786427de7a284b4cb
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Thu Jan 26 08:32:27 2017

Disable swarming for tests where it's disabled on builder level (FYI masters)

See https://codereview.chromium.org/2649923009/ for previous CL
for production builders.

BUG= 684527 , 684067
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
R=bajones@chromium.org, kbr@chromium.org, maruel@chromium.org

Review-Url: https://codereview.chromium.org/2652223002 .
Cr-Commit-Position: refs/heads/master@{#446277}

[modify] https://crrev.com/c4902f0922c2f1553486109786427de7a284b4cb/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/c4902f0922c2f1553486109786427de7a284b4cb/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/c4902f0922c2f1553486109786427de7a284b4cb/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ec5a4e0e68acaa55f3363ceec7523c990c0bba5

commit 6ec5a4e0e68acaa55f3363ceec7523c990c0bba5
Author: mbjorge <mbjorge@chromium.org>
Date: Thu Mar 30 22:07:43 2017

[Chromecast] Fix Cast Audio Linux bot swarming settings.

content_browsertests fails on swarming. Don't run on swarming to match the configuration of the Cast Linux bot, where content_browsertests is passing.

Also remove ppapi unittests to match Cast Linux config; they should not have been added in the first place.

BUG= 706555 ,  684527 

Review-Url: https://codereview.chromium.org/2785243002
Cr-Commit-Position: refs/heads/master@{#460902}

[modify] https://crrev.com/6ec5a4e0e68acaa55f3363ceec7523c990c0bba5/testing/buildbot/chromium.linux.json

Sign in to add a comment