New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684498 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Data race in base::GlobalHistogramAllocator::Get

Project Member Reported by ClusterFuzz, Jan 24 2017

Issue description

Cc: msrchandra@chromium.org
Components: Blink>Scheduling
Labels: Test-Predator-Correct-CLs
Owner: alexclarke@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Find it results --
The result is a list of CLs that change the crashed files. 

Author: alexclarke
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/0f557845036944f7f4013860fcdbff547f08d172
Time: Mon Jan 23 21:47:38 2017
File task_queue_manager.cc is changed in this cl (and is part of stack frame #4, "blink::scheduler::TaskQueueManager::MaybeRecordTaskDelayHistograms"; frame #5, "blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue"; frame #6, "blink::scheduler::TaskQueueManager::DoWork")
Minimum distance from crash line to modified line: 16. (file: task_queue_manager.cc, crashed on: 245, modified: 229).

@alexclarke -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: -msrchandra@chromium.org
Owner: msrchandra@chromium.org
https://codereview.chromium.org/2649813003 is a pure refactor and did not cause this.
Cc: msrchandra@chromium.org
Labels: -Test-Predator-Correct-CLs Test-Predator-Wrong-CLs
Owner: bcwh...@chromium.org
Thank You Alexclarke.

Using Code Search for the file, "persistent_histogram_allocator.cc" assigning to the concern owner.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/4bc446aaa33205d3d1573cc90c8801edcef88922

@bcwhite -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7d5177f1f8d47bcae75304d19b2728533e267f6

commit a7d5177f1f8d47bcae75304d19b2728533e267f6
Author: bcwhite <bcwhite@chromium.org>
Date: Tue Jan 24 20:59:28 2017

Use atomic ops for managing g_allocator.

BUG= 684498 

Review-Url: https://codereview.chromium.org/2655673002
Cr-Commit-Position: refs/heads/master@{#445805}

[modify] https://crrev.com/a7d5177f1f8d47bcae75304d19b2728533e267f6/base/metrics/persistent_histogram_allocator.cc

Cc: nyerramilli@chromium.org alexclarke@chromium.org bcwh...@chromium.org
 Issue 685048  has been merged into this issue.
Labels: Merge-Request-57
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by gov...@chromium.org, Jan 30 2017

Please merge  your change to M57 branch 2987 ASAP.If merge happens today before 5:00 PM PT, then we can take it for tomorrow's last M57 Dev release. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 30 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9271f371324eb165ba5f6ec24d1f1aba0d26165d

commit 9271f371324eb165ba5f6ec24d1f1aba0d26165d
Author: Brian White <bcwhite@chromium.org>
Date: Mon Jan 30 21:51:01 2017

Use atomic ops for managing g_allocator.

BUG= 684498 

Review-Url: https://codereview.chromium.org/2655673002
Cr-Commit-Position: refs/heads/master@{#445805}
(cherry picked from commit a7d5177f1f8d47bcae75304d19b2728533e267f6)

Review-Url: https://codereview.chromium.org/2665893002 .
Cr-Commit-Position: refs/branch-heads/2987@{#191}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/9271f371324eb165ba5f6ec24d1f1aba0d26165d/base/metrics/persistent_histogram_allocator.cc

Status: Fixed (was: Assigned)

Sign in to add a comment