New issue
Advanced search Search tips

Issue 684489 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

WebView should get the multiprocess-enabled flag from the system instead of checking the setting itself

Project Member Reported by torne@chromium.org, Jan 24 2017

Issue description

WebView currently fetches the multiprocess setting from the settings provider itself; it should instead ask the framework if multiprocess should be enabled, so that the logic can be controlled by the system.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acc84fbd540feec6c0fa6b2165b0da7eeb8d0456

commit acc84fbd540feec6c0fa6b2165b0da7eeb8d0456
Author: torne <torne@chromium.org>
Date: Tue Jan 24 11:59:34 2017

Prepare to get the multiprocess setting from WebViewDelegate.

In future OS versions, we should fetch the multiprocess-enabled setting
from WebViewDelegate instead of querying the setting directly. Add the
skeleton code to get this from the delegate under a build version
condition.

BUG= 684489 

Review-Url: https://codereview.chromium.org/2645413002
Cr-Commit-Position: refs/heads/master@{#445705}

[modify] https://crrev.com/acc84fbd540feec6c0fa6b2165b0da7eeb8d0456/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/acc84fbd540feec6c0fa6b2165b0da7eeb8d0456/android_webview/glue/java/src/com/android/webview/chromium/WebViewDelegateFactory.java

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/230945220b3bede53fbfe89c33c6ac778196be71

commit 230945220b3bede53fbfe89c33c6ac778196be71
Author: Torne (Richard Coles) <torne@google.com>
Date: Tue Jan 24 11:59:31 2017

Comment 3 by torne@chromium.org, Jan 24 2017

Labels: Merge-Request-57
Need to merge to M57 so we can test multiprocess with M57 builds in android.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 24 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/017527dfefa5007676c3acd72c957e8dda04742f

commit 017527dfefa5007676c3acd72c957e8dda04742f
Author: Torne (Richard Coles) <torne@chromium.org>
Date: Tue Jan 24 13:49:12 2017

Prepare to get the multiprocess setting from WebViewDelegate.

In future OS versions, we should fetch the multiprocess-enabled setting
from WebViewDelegate instead of querying the setting directly. Add the
skeleton code to get this from the delegate under a build version
condition.

BUG= 684489 

Review-Url: https://codereview.chromium.org/2645413002
Cr-Commit-Position: refs/heads/master@{#445705}
(cherry picked from commit acc84fbd540feec6c0fa6b2165b0da7eeb8d0456)

Review-Url: https://codereview.chromium.org/2649273004 .
Cr-Commit-Position: refs/branch-heads/2987@{#56}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/017527dfefa5007676c3acd72c957e8dda04742f/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/017527dfefa5007676c3acd72c957e8dda04742f/android_webview/glue/java/src/com/android/webview/chromium/WebViewDelegateFactory.java

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/128508d099fd2068a0c13467e0134a21b92d366c

commit 128508d099fd2068a0c13467e0134a21b92d366c
Author: Torne (Richard Coles) <torne@google.com>
Date: Tue Jan 24 11:59:31 2017

Comment 7 by torne@chromium.org, Jan 24 2017

Status: Fixed (was: Started)
Verified, Multiprocess is on by default, tested on Pixel XL/ORG31 Monochrome System image: 57.0.2987.9, Monochrome Dev: 57.0.2987.19

Sign in to add a comment