bluetooth: Bluetooth chooser buttons order should be reversed in MacOS |
|||||
Issue descriptionChrome Version: 58.0.2991.0 on macOS Sierra "Pair" & "Cancel" buttons order in the Bluetooth chooser is not consistent with other modal dialog buttons order in Chrome. See attached screenshots. Instead of [ PAIR ] [ CANCEL ] It should be [ CANCEL ] [ PAIR ]
,
Jan 24 2017
,
Jan 24 2017
rolfe@, what do you think?
,
Jan 24 2017
+ hwi for desktop dialog thoughts. What do you recommend in this case? (First our dialog shows, then the OS one.) Not sure in what way to structure our buttons (will they be consistent no matter the platform on Harmony?)
,
Jan 24 2017
Here're pointers to the button order rules on Chrome. - Yes/No on Windows/ChromeOS - No/Yes on OSX/iOS/Android/Andromeda/Linux - Implement using the base class or one like it https://cs.chromium.org/chromium/src/ui/views/window/dialog_client_view.cc?rcl=1446132566&l=31 https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/node_utils.js?l=15
,
Jan 24 2017
Thanks! I'll change that then.
,
Jan 24 2017
Here is the screenshot.
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f5c7c7e52c0983aaa111f7a6ccc7003ad737fad commit 0f5c7c7e52c0983aaa111f7a6ccc7003ad737fad Author: juncai <juncai@chromium.org> Date: Tue Jan 24 23:23:49 2017 Change the Bluetooth chooser buttons order to be Cancel/Pair on MacOS This CL changes the Bluetooth chooser buttons order to be Cancel/Pair to make them consistent with other dialog buttons in Chrome. I uploaded a screenshot on the issue page. BUG= 684479 Review-Url: https://codereview.chromium.org/2649323006 Cr-Commit-Position: refs/heads/master@{#445853} [modify] https://crrev.com/0f5c7c7e52c0983aaa111f7a6ccc7003ad737fad/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm
,
Jan 24 2017
Thanks juncai@! To clarify, will other platforms also follow the rule on c#5?
,
Jan 24 2017
Yes, Bluetooth chooser on other platforms already follows the rule on c#5.
,
Jan 24 2017
Thanks!
,
Jan 24 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fbeaufort@chromium.org
, Jan 24 2017