New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684479 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

bluetooth: Bluetooth chooser buttons order should be reversed in MacOS

Project Member Reported by fbeaufort@chromium.org, Jan 24 2017

Issue description

Chrome Version: 58.0.2991.0 on macOS Sierra

"Pair" & "Cancel" buttons order in the Bluetooth chooser is not consistent with other modal dialog buttons order in Chrome. See attached screenshots.

Instead of       [ PAIR ]  [ CANCEL ]

It should be     [ CANCEL ]  [ PAIR ]


 
Screen Shot 2017-01-24 at 11.51.31 AM.png
34.3 KB View Download
Screen Shot 2017-01-24 at 11.47.46 AM.png
280 KB View Download
Screen Shot 2017-01-24 at 11.40.49 AM.png
90.7 KB View Download
Screen Shot 2017-01-24 at 11.41.13 AM.png
79.6 KB View Download
Summary: bluetooth: Bluetooth chooser buttons order should be reversed in MacOS (was: bluetooth: Scan doesn't work on MacOS)

Comment 2 by scheib@chromium.org, Jan 24 2017

Status: Available (was: Untriaged)
added to go/wbbacklog.

Comment 3 by juncai@chromium.org, Jan 24 2017

Cc: -juncai@chromium.org rolfe@chromium.org
Owner: juncai@chromium.org
Status: Assigned (was: Available)
rolfe@, what do you think?

Comment 4 by rolfe@chromium.org, Jan 24 2017

Cc: hwi@chromium.org
+ hwi for desktop dialog thoughts. What do you recommend in this case? (First our dialog shows, then the OS one.) Not sure in what way to structure our buttons (will they be consistent no matter the platform on Harmony?)

Comment 5 by hwi@chromium.org, Jan 24 2017

Here're pointers to the button order rules on Chrome. 

- Yes/No on Windows/ChromeOS

- No/Yes on OSX/iOS/Android/Andromeda/Linux

- Implement using the base class or one like it

https://cs.chromium.org/chromium/src/ui/views/window/dialog_client_view.cc?rcl=1446132566&l=31

https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/node_utils.js?l=15


Comment 6 by juncai@chromium.org, Jan 24 2017

Status: Started (was: Assigned)
Thanks! I'll change that then.

Comment 7 by juncai@chromium.org, Jan 24 2017

Here is the screenshot.
chooser.png
88.1 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f5c7c7e52c0983aaa111f7a6ccc7003ad737fad

commit 0f5c7c7e52c0983aaa111f7a6ccc7003ad737fad
Author: juncai <juncai@chromium.org>
Date: Tue Jan 24 23:23:49 2017

Change the Bluetooth chooser buttons order to be Cancel/Pair on MacOS

This CL changes the Bluetooth chooser buttons order to be Cancel/Pair
to make them consistent with other dialog buttons in Chrome.

I uploaded a screenshot on the issue page.

BUG= 684479 

Review-Url: https://codereview.chromium.org/2649323006
Cr-Commit-Position: refs/heads/master@{#445853}

[modify] https://crrev.com/0f5c7c7e52c0983aaa111f7a6ccc7003ad737fad/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm

Comment 9 by hwi@chromium.org, Jan 24 2017

Thanks juncai@! To clarify, will other platforms also follow the rule on c#5? 
Yes, Bluetooth chooser on other platforms already follows the rule on c#5.

Comment 11 by hwi@chromium.org, Jan 24 2017

Thanks!
Status: Fixed (was: Started)

Sign in to add a comment