New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684445 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 419413


Show other hotlists

Hotlists containing this issue:
web-bluetooth


Sign in to add a comment

bluetooth: Improve GATT disconnected error message

Project Member Reported by fbeaufort@chromium.org, Jan 24 2017

Issue description

Chrome Version: 58.0.2991.0

What steps will reproduce the problem?
Execute code below:

  navigator.bluetooth.requestDevice({filters: [{services: ['battery_service']}]})
  .then(device => device.gatt.getPrimaryService('battery_service'))
  .then(service => service.getCharacteristic('battery_level'))
  .then(characteristic => characteristic.readValue())
  .then(value => {
    let batteryLevel = value.getUint8(0);
    console.log('> Battery Level is ' + batteryLevel + '%');
  })
  .catch(error => {
    console.log('Argh! ' + error);
  });
}


What is the expected result?

An error message explains clearly what is happening...
I wish it would say something like "GATT Server is NOT connected. Please (re)connect first with `device.gatt.connect` to retrieve services".


What happens instead?

I get this error: "Argh! NetworkError: GATT Server is disconnected. Cannot retrieve services."


For info, I've seen real users having hard time figuring out what was wrong with their code when playing with Web Bluetooth. I believe this little tweak could improve their journey to solve this.
 

Comment 1 by scheib@chromium.org, Jan 24 2017

Owner: scheib@chromium.org
Status: Started (was: Untriaged)

Comment 2 by scheib@chromium.org, Jan 26 2017

ortuno points out that this also should be done for services, characteristics
https://cs.chromium.org/search/?q=kgattservernotconnected&sq=package:chromium&type=cs
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e43caf1c8478ce34a810418b55ddb244a29248b

commit 1e43caf1c8478ce34a810418b55ddb244a29248b
Author: scheib <scheib@chromium.org>
Date: Sat Jan 28 03:13:57 2017

bluetooth: Improve GATT disconnected error message.

BluetoothRemoteGATTServer.cpp:
Suggest corrective action of calling gatt.connect when an operation
fails due to being disconnected.

Also, reduce required number of strings by merging two similar
error messages given a disconnected state. It doesn't matter
if the device was already disconnected or became disconnected
after an operation has already started. In both cases the
action that must be taken is to connect again.

generate.py:
Generated layout tests must now deal with 'git cl format' causing
template .js files to have line breaks. The regular expression
is updated to accomodate this.

BUG= 684445 

Review-Url: https://codereview.chromium.org/2652163002
Cr-Commit-Position: refs/heads/master@{#446895}

[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/generate.py
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/device-disconnects-before.js
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/garbage-collection-ran-during-error.js
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/garbage-collection-ran-during-success.js
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/device-disconnects-during-error.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/device-disconnects-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/device-reconnects-during-error.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/device-reconnects-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/disconnect-called-before.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/disconnect-called-during-error.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/disconnect-called-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/disconnected-device.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-device-disconnects-before.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-garbage-collection-ran-during-error.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-garbage-collection-ran-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/reconnect-during-error.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/reconnect-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/device-disconnects-during-error-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/device-disconnects-during-success-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/device-disconnects-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/device-reconnects-during-error-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/device-reconnects-during-success-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/device-reconnects-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/disconnect-called-before-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/disconnect-called-before.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/disconnect-called-during-error-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/disconnect-called-during-success-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/disconnect-called-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/disconnected-device-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/disconnected-device.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-device-disconnects-before-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-device-disconnects-before.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-error-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-error.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-success-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/reconnect-during-error-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/reconnect-during-success-with-uuid.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/reconnect-during-success.html
[modify] https://crrev.com/1e43caf1c8478ce34a810418b55ddb244a29248b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

Comment 4 by scheib@chromium.org, Feb 16 2017

Blocking: 419413
Cc: scheib@chromium.org
Owner: ortuno@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e

commit c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e
Author: ortuno <ortuno@chromium.org>
Date: Wed Mar 08 09:24:13 2017

bluetooth: Better disconnected error messages for characteristic retrieval.

Also refactor how disconnected messages are generated.

BUG= 684445 

Review-Url: https://codereview.chromium.org/2721233002
Cr-Commit-Position: refs/heads/master@{#455413}

[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/garbage-collection-ran-during-error.js
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/garbage-collection-ran-during-success.js
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/device-disconnects-before.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/device-disconnects-during.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/disconnect-called-before.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/disconnect-called-during.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-garbage-collection-ran-during-error.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-garbage-collection-ran-during-success.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/reconnect-during.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/device-disconnects-before-with-uuid.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/device-disconnects-before.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/device-disconnects-during-with-uuid.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/device-disconnects-during.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/disconnect-called-before-with-uuid.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/disconnect-called-before.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/disconnect-called-during-with-uuid.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/disconnect-called-during.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-garbage-collection-ran-during-error-with-uuid.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-garbage-collection-ran-during-error.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-garbage-collection-ran-during-success-with-uuid.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-garbage-collection-ran-during-success.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/reconnect-during-with-uuid.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/reconnect-during.html
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/Source/modules/bluetooth/BluetoothError.h
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
[modify] https://crrev.com/c71e0a42a3eb47e551bafaa4e5d53f481a9bf89e/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/258758c687d31cc18e1f9f0395a8714df0187202

commit 258758c687d31cc18e1f9f0395a8714df0187202
Author: ortuno <ortuno@chromium.org>
Date: Fri Mar 10 00:48:01 2017

bluetooth: Improve error message for retrieving Descriptors when disconnecting

Changes characteristic.getDescriptor(s) to return a more actionable error.

BUG= 684445 

Review-Url: https://codereview.chromium.org/2728813002
Cr-Commit-Position: refs/heads/master@{#455929}

[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-device-disconnects-before.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-device-disconnects-during-error.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-device-disconnects-during-success.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-disconnect-called-before.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-disconnect-called-during-error.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-disconnect-called-during-success.html
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-success.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-before.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-during-error.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-device-disconnects-during-success.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-before.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-during-error.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-gatt-op-disconnect-called-during-success.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-before-with-uuid.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-before.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-error-with-uuid.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-error.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-success-with-uuid.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-success.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-before-with-uuid.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-before.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-error-with-uuid.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-error.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-success-with-uuid.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-success.html
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error-with-uuid.html
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error.html
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success-with-uuid.html
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-before-with-uuid.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-before.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-error-with-uuid.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-error.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-success-with-uuid.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-device-disconnects-during-success.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-before-with-uuid.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-before.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-error-with-uuid.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-error.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-success-with-uuid.html
[delete] https://crrev.com/347e05c9fcda35ab2fd31cd7e7b9d89bc10aed26/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-gatt-op-disconnect-called-during-success.html
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-device-disconnects-before.js
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-device-disconnects-during-error.js
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-device-disconnects-during-success.js
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-disconnect-called-before.js
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-disconnect-called-during-error.js
[add] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-disconnect-called-during-success.js
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-error.js
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/descriptor-garbage-collection-ran-during-success.js
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-before.js
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-during-error.js
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-device-disconnects-during-success.js
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-before.js
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-during-error.js
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic/gatt-op-disconnect-called-during-success.js
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/Source/modules/bluetooth/BluetoothError.h
[modify] https://crrev.com/258758c687d31cc18e1f9f0395a8714df0187202/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

Comment 9 by ortuno@chromium.org, Apr 26 2017

Status: Fixed (was: Started)

Sign in to add a comment