alemate@ this is currently a stable blocker. Can you please confirm the issue and let us know if this is something you will be working on?

Can we confirm if this is actually affecting 57?  I'm guessing it's part of the new OOBE so 58.

Assigning to Steven.


Steven, this looks like a system-wide issue. WDYT?

Why is this a system-wide issue? The problem as I understand it is that we are allowing the OOBE flow when we connect to Cellular, even though WiFi is enabled. That seems like something we should be checking for in OOBE.

(Shill will connect to Cellular as soon as it is available, that is expected behavior. It will switch to WiFi as soon as a WiFi network is available).

I can go ahead and look into this. It is only MD OOBE so fixing this for 58 should be fine.

Well, I don't know the details of our network configuration, but I expected it to be the same across all our UI. But if you think this is OOBE-specific, let's fix it for OOBE only.

I'm just not sure what you mean by "it to be the same"? Auto connect to Cellular is expected, we don't want to "fix" that.

But why not close this as WintFix, as we expect Cellular to be auto-connected? I mean "if we allow two connections during in user session, why not to allow this for OOBE" ?

Oh, I misunderstood the bug (I just looked at the video). I thought we were auto advancing with a Cellular connection.

It is a little confusing to allow the user to click on a connected Cellular network to advance; it implies that the Cellular connection is being selected to be the active connection but that isn't actually what is occurring. Chrome OS will always prefer WiFi over Cellular when connected to both.

I think we should probably change the UI to not advance if a non primary connected network is clicked on (e.g. a Cellular network when we are connected to WiFi).

This doesn't seem like a P1 blocking issue.

In theory we have a similar issue with Ethernet and WiFi; if a WiFi network is selected we move forward, implying that WiFi is used when in practice Ethernet is used.

The simplest fix here is to only progress if the default network (i.e. the first network) is selected or becomes connected.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac4e96b732785a4a296f74db6e9b60ef8af04f2

commit 1ac4e96b732785a4a296f74db6e9b60ef8af04f2
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Sep 22 23:45:26 2017

OOBE: Network: Do not advance when non default network is selected

Bug:  684413 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I347a8b4d888ea952e12ca6f588bba7dd2bb7f6b0
Reviewed-on: https://chromium-review.googlesource.com/673715
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503906}
[modify] https://crrev.com/1ac4e96b732785a4a296f74db6e9b60ef8af04f2/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/1ac4e96b732785a4a296f74db6e9b60ef8af04f2/ui/webui/resources/cr_elements/chromeos/network/cr_network_select.js