New issue
Advanced search Search tips

Issue 684403 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: warn users that JavaScript is disabled in DevTools settings.

Reported by gzoe...@gmail.com, Jan 24 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.67 Safari/537.36

Steps to reproduce the problem:
1. 
Ctrl+t (to open new tab)
2. 
F12 (to open browser tools)
3. 
try to enter text in the search field "Search Google or type URL

When I navigate explicitly to https://www.google.at then I can enter text in the search field though

On https://plnkr.co/edit/dmEIFLISpX5SnjhAknyl?p=preview (default Angular2 template offered by the new button) I also can't do anything when devtools are open.
I also saw this on other pages

What is the expected behavior?
DevTools should not block the browser tab.

What went wrong?
DevTools opened blocks the browser 

Did this work before? Yes don't know

Chrome version: 56.0.2924.67  Channel: beta
OS Version: Linux zdev 4.8.0-2-amd64 #1 SMP Debian 4.8.15-2 (2017-01-04) x86_64 GNU/Linux
Flash Version: Shockwave Flash 24.0 r0

I don't know the last version where it worked. I have this since a few weeks. I assumed it's a Plunker issue because this is where it causes issues for me but with Plunker and Angular2 there were often all kinds of issues. 
Just yesterday I recognized that this is on other sites as well.
 
Labels: Needs-Triage-M56

Comment 2 by gzoe...@gmail.com, Jan 24 2017

When I run the browser from the command line using `/opt/google/chrome-beta/chrome` instead of the KDE start menu icon, I can't reproduce.

I don't know what is different when run from console :-/
Cc: rbasuvula@chromium.org
Labels: -Needs-Triage-M56 Needs-Feedback
Tested the issue in chrome #56.0.2924.67 and latest build #58.0.2992.0 on Ubuntu 14.04 and not able to reproduce the issue.Please find the screen shot for reference.
@gzoechi: Could you please let me know if i have missed anything and if possible,Please create a new profile without extension and recheck once.Let us know the observations which would help us to triage the issue further.

Thank you in advance!
684403.png
114 KB View Download

Comment 4 by gzoe...@gmail.com, Jan 26 2017

I disabled all extensions and plugins in my default profile, still the same issue.

Currently on version V8 5.6.326.42 (just updated)

When I use a different profile I, I also can't reproduce.

Any idea how to debug. I'm not used to debugging issues in Chrome.
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 2 2017

Labels: -Needs-Feedback Needs-Review
Owner: rbasuvula@chromium.org
Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gzoe...@gmail.com, Feb 2 2017

I found the cause. JavaScript was disabled in the console.
I intended to only temporarily disable it but forgot to re-enable.

It would be real great if it could be shown more prominently when JS is disabled.  


Owner: pfeldman@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: DevTools: warn users that JavaScript is disabled in DevTools settings. (was: Opening developer tools completely blocks page)
Owner: l...@chromium.org
1) We could show a warning icon next to Sources panel similarly to how we show one for throttling
2) We could make this setting temporary (non-persistent).

Let's start with (1)

Comment 9 by l...@chromium.org, Feb 2 2017

Labels: -Type-Bug-Regression Type-Bug
We already do the icon next to sources.  The warning icon can be hard to notice, so perhaps we need a better indicator (console message?) or pfeldman@'s 2nd suggestion.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d86ba3089c88fd85df42b2660bf5dd8a2cda6dfe

commit d86ba3089c88fd85df42b2660bf5dd8a2cda6dfe
Author: luoe <luoe@chromium.org>
Date: Mon Mar 06 18:04:07 2017

DevTools: make disable javascript setting temporary

This makes the "disable javascript" setting temporary, similar to
networkBlockedURLs. Before, disabling JS then opening a new tab with DevTools
resulted in disabled JS on the new tab. Now, opening DevTools in the new tab
will not have the same setting as the last tab.

Behavior when closing/opening DevTools on the same tab, navigating the page, and
toggling the checkbox should not be affected by this CL.

BUG= 684403 

Review-Url: https://codereview.chromium.org/2708413003
Cr-Commit-Position: refs/heads/master@{#454885}

[modify] https://crrev.com/d86ba3089c88fd85df42b2660bf5dd8a2cda6dfe/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/d86ba3089c88fd85df42b2660bf5dd8a2cda6dfe/third_party/WebKit/Source/devtools/front_end/common/Settings.js
[modify] https://crrev.com/d86ba3089c88fd85df42b2660bf5dd8a2cda6dfe/third_party/WebKit/Source/devtools/front_end/help/Help.js
[modify] https://crrev.com/d86ba3089c88fd85df42b2660bf5dd8a2cda6dfe/third_party/WebKit/Source/devtools/front_end/main/module.json
[modify] https://crrev.com/d86ba3089c88fd85df42b2660bf5dd8a2cda6dfe/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
[modify] https://crrev.com/d86ba3089c88fd85df42b2660bf5dd8a2cda6dfe/third_party/WebKit/Source/devtools/front_end/sdk/module.json

Labels: -Needs-Review
Cleaning up sheriffbot label "Needs-Review" label as a part of modified "Needs-Feedback" sheriffbot rule. [ref bug for cleanup 684919]

Comment 12 by l...@chromium.org, Mar 28 2017

Status: Fixed (was: Assigned)
Now that the setting checkbox is temporary, there should be less confusion.

Sign in to add a comment