New issue
Advanced search Search tips

Issue 684396 link

Starred by 11 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Adblock Plus crashes, nullptr check failed

Reported by d...@adblockplus.org, Jan 24 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce the problem:
1. Launch Chrome canary with the --enable-logging --v=1 --no-sandbox parameters.
2. Install the 1.12.4.1724 development build of Adblock Plus https://downloads.adblockplus.org/devbuilds/adblockpluschrome/adblockpluschrome-1.12.4.1724.crx
3. If the extension does not immediately crash click to reload the extension.

What is the expected behavior?
The extension does not crash. No error is displayed

What went wrong?
The extension crashes. The following error is displayed in the command line by Chrome each time the extension is reloaded:

#
# Fatal error in c:\b\build\slave\win64-pgo\build\src\v8\src\handles.h, line 217
# Check failed: (location_) != nullptr.
#

==== C stack trace ===============================

        ChromeMain [0x00007FFD42898E1F+5933403]
        ChromeMain [0x00007FFD42CB2411+10231629]
        ChromeMain [0x00007FFD428C7EA6+6126050]
        ovly_debug_event [0x00007FFD41D957CD+63037]
        ovly_debug_event [0x00007FFD41D95587+62455]
        ovly_debug_event [0x00007FFD41DB15CF+177215]
        ovly_debug_event [0x00007FFD41DB13A8+176664]
        ovly_debug_event [0x00007FFD41E26CF8+658280]
        ovly_debug_event [0x00007FFD41EE70B5+1445669]
        ovly_debug_event [0x00007FFD41EE7013+1445507]
        ovly_debug_event [0x00007FFD41EE6FA3+1445395]
        (No symbol) [0x000002ACCC90442B]

WebStore page: https://chrome.google.com/webstore/detail/adblock-plus/cfhdojbkjhnklbpkdaibdccddilifddb

Did this work before? Yes Not sure, stable (55) works.

Chrome version: 58.0.2990.0  Channel: canary
OS Version: 10 (Version 1607)
Flash Version: Unsure

Related issue on our issue tracker: https://issues.adblockplus.org/ticket/4835
 
Argh, I meant to type "Window 10 (Version 1607)" for the OS version. Also please ignore the UserAgent string since I was testing in a virtual machine.
Labels: Needs-Triage-M58 Needs-Bisect

Comment 3 by infra...@gmail.com, Jan 25 2017

See https://bugs.chromium.org/p/chromium/issues/detail?id=684374 for a crash report from Canary due to this.
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Windows 10, Mac 10.12.2 & Linux ubuntu 14.04 with chrome stable#55.0.2883.87 , Canary#58.0.2991.0 & reported version# 58.0.2990.0 as per the steps mentioned in comment#0.

Note: Crash observed when chrome launched without flag "--enable-logging --v=1 --no-sandbox parameters".

Please find the attached screencast for reference and let us know if we miss any steps to reproduce the issue.

Thanks.

684396.mp4
1.8 MB View Download
it seems fixed (the ABP issue) in the last Version 58.0.2992.0 canary (64-bit)
I watched your video but it appeared you did not attempt to reload the extension (step 3).

Apparently the regression is fixed in more recent versions but it would still be nice if you could reproduce this issue in the reported version and confirm that it no longer occurs.
Dave@,

As per comment#6, Please find the attached screencast of the reported version where issue is working as expected.

Could you please check & update the thread.

Thank you.




684396 on reported version.mp4
10.1 MB View Download

Comment 8 Deleted

It seems you've also passed the parameter of "parameter", perhaps by pasting the parameters from my earlier message? Here's the command I type to run Chrome (from the correct directory):

chrome.exe --enable-logging --v=1 --no-sandbox

When I run Chrome like that I do not see the string "parameter" at the end of the Command Line section of chrome://version . Instead I see this:

chrome.exe --enable-logging --v=1 --no-sandbox --flag-switches-begin --flag-switches-end
@Dave,

As per comment#9 ,tested this issue with flag "--enable-logging --v=1 --no-sandbox" on windows (reported version-55.0.2883.87) and observed that 'Adblock Plus' extension added successfully without any crash.

Please find the attached screencast for reference.

Thanks!!
684396-Jan 30th.mp4
5.2 MB View Download
The bug happens with Chromium 58.0.2990.0 (Channel: canary). As mentioned in my issue description I tested under a virtual machine and therefore my user agent should be ignored.

(It looks like the parameters are right this time at least.)
Labels: TE-NeedsTriageFromMTV
Could anybody from MTV team please look into this issue as Chrome-Hyd team do not have access to virtual machines to triage this issue.

Adding respective label to the issue.

Thanks in advance.

But according to your eaarlier comments previously you were able to test version 58.0.2990.0 on Mac, Windows and Linux?
(Sorry, typed that one on my phone! Earlier comment*)
Labels: -TE-NeedsTriageFromMTV
Unable to reproduce the issue on Windows virtual machine using chrome reported# 58.0.2990.0  & latest Canary#canary #58.0.2999.4 as per the below steps:

1.Launched Chrome canary with flag "--enable-logging --v=1 --no-sandbox parameters" / "--enable-logging --v=1 --no-sandbox" (tried with both)
2.Added extension(Adblock Plus) from step2 of Comment#0.
3.Reloaded the chrome extensions page
4.Adblock Plus extension added successfully.
5.Not observed any crash

Please check the issue on latest canary #58.0.2999.4 from your end & if still issue exists, provide us the crash id from chrome://crashes to compare the issue with #683867.

Thanks in advance!!




I've not seen a screencast where you get both the parameters and the Chromium version correct and reload the extension, but I'll take your word for it.

As for testing a more recent version we already mentioned (comment #5) that the problem seems to have been fixed in more recent versions.
Status: WontFix (was: Unconfirmed)
Thanks for your replt.

Please find the attached screencast on Windows reported version#58.0.2990.0 -chrome enabled with falg,able to add the 'Adblock Plus' extension successfully.

Marking this issue as Wontfix as per comment#16.
ABP-VM.webm
2.4 MB View Download

Sign in to add a comment