New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684387 link

Starred by 1 user
Status: Fixed
Owner:
█ kjellander@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
█ sakal@chromium.org
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue webrtc:6804



Sign in to add a comment

Setup Android SDK bot building the .aar archive.

Project Member Reported by kjellander@chromium.org, Jan 24 2017 
As part of https://bugs.chromium.org/p/webrtc/issues/detail?id=7023 a new Python script is developed (https://codereview.webrtc.org/2653533004/) that shall be used to build the SDK into an Android .aar archive file.

We should setup a new Android bot that performs this build and archives the build output to Google storage, similar to what we do for iOS in this recipe: https://cs.chromium.org/chromium/build/scripts/slave/recipes/webrtc/ios_api_framework.py

Similar CLs:
https://codereview.chromium.org/1865653002/
https://codereview.chromium.org/2011973003/ (no need to do in a separate CL).

Sami: What would be a good name for the bot? "Android SDK Framework" or just "Android SDK"? I'm not familiar with exactly what terms are usually used.

The buildbot should be accompanied with a trybot, which needs to be added to the default set of trybots (infra/config/cq.cfg).

Comment 1 by kjellander@chromium.org, Jan 24 2017

Blocking: webrtc:6804

Comment 2 by sakal@chromium.org, Jan 24 2017 

Quoting https://developer.android.com/studio/projects/android-library.html

"Android library compiles into an Android Archive (AAR)"

Usually Android SDK refers to the Android build tools. So naming the bot "Android SDK" could be a little confusing. Therefore, I would prefer "Android Archive" or something similar.

Comment 3 by kjellander@chromium.org, Feb 3 2017

Owner: kjellander@chromium.org
Status: Started (was: Available)
I'll do this one. I'm setting up the new branches master in https://chromium-review.googlesource.com/c/437006/
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/6b3fcfd82318aea0cd4ce1705f510ece0057491a

commit 6b3fcfd82318aea0cd4ce1705f510ece0057491a
Author: kjellander <kjellander@webrtc.org>
Date: Tue Feb 07 09:11:06 2017

Add support for extra GN args to Android build script.

By using the --extra-gn-args flag, it is now possible to
specify additional GN arguments for the build. This is needed
in order to pass a non-default Goma directory (needed for the bots).
Example use: --extra-gn-args goma_dir=\"/path/to/goma\"
You can also pass multiple args (separated by spaces).

BUG= chromium:684387 
NOTRY=True
TESTED=Did a local successful run.

Review-Url: https://codereview.webrtc.org/2670743004
Cr-Commit-Position: refs/heads/master@{#16458}

[modify] https://crrev.com/6b3fcfd82318aea0cd4ce1705f510ece0057491a/tools-webrtc/android/build_aar.py

Comment 8 by kjellander@chromium.org, Feb 7 2017

Status: Fixed (was: Started)
Finally done. First green build https://build.chromium.org/p/client.webrtc.fyi/builders/Android%20Archive/builds/21

The 'gsutil upload' link on that page can be used to download the archive.
I'll setup this bot along with others in the new branches waterfall when it's ready.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2f786c086d8f538c54f8f97a35575e74bafe6bd5

commit 2f786c086d8f538c54f8f97a35575e74bafe6bd5
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Feb 08 10:39:47 2017

WebRTC: New master for building branches.

BUG= 688286 ,  684387 

Change-Id: Ic72c0ec4de7ceda1728a09f038e4876d7c2409b6
Reviewed-on: https://chromium-review.googlesource.com/437006
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[add] https://crrev.com/2f786c086d8f538c54f8f97a35575e74bafe6bd5/masters/master.client.webrtc.branches/templates/description.html
[add] https://crrev.com/2f786c086d8f538c54f8f97a35575e74bafe6bd5/masters/master.client.webrtc.branches/slaves.cfg
[modify] https://crrev.com/2f786c086d8f538c54f8f97a35575e74bafe6bd5/tests/masters_test.py
[add] https://crrev.com/2f786c086d8f538c54f8f97a35575e74bafe6bd5/masters/master.client.webrtc.branches/master_site_config.py
[add] https://crrev.com/2f786c086d8f538c54f8f97a35575e74bafe6bd5/masters/master.client.webrtc.branches/Makefile
[add] https://crrev.com/2f786c086d8f538c54f8f97a35575e74bafe6bd5/masters/master.client.webrtc.branches/master.cfg
[add] https://crrev.com/2f786c086d8f538c54f8f97a35575e74bafe6bd5/masters/master.client.webrtc.branches/branches_cfg.py
[add] https://crrev.com/2f786c086d8f538c54f8f97a35575e74bafe6bd5/masters/master.client.webrtc.branches/OWNERS
►

Sign in to add a comment