Protobuf dependencies are not checked in PRESUBMIT. |
||
Issue descriptionCurrent implementation of buildtools' checkdeps does not check dependencies for protobuf files and one can include or import a protobuf without specifying DEP rules for that. Desired behavior is checking protos dependencies as well.
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dcd76d7f39b82db6f216041f0e7751b0b98a306 commit 0dcd76d7f39b82db6f216041f0e7751b0b98a306 Author: rhalavati <rhalavati@chromium.org> Date: Mon Feb 27 13:57:27 2017 Build tools revision updated. Protobuf dependency check is added to build tools and revision updated after that. BUG= 684383 TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2716353002 Cr-Commit-Position: refs/heads/master@{#453203} [modify] https://crrev.com/0dcd76d7f39b82db6f216041f0e7751b0b98a306/DEPS
,
Feb 27 2017
I will close this bug, but another one is created to follow up work on partial dependencies: www.crbug.com/691451
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08acd23b2515d32a9f107a5d71555d7b2270c0f8 commit 08acd23b2515d32a9f107a5d71555d7b2270c0f8 Author: rhalavati <rhalavati@chromium.org> Date: Mon Apr 03 07:23:28 2017 Dependancy check for .proto files is added to PRESUBMIT. In a separate CL (https://codereview.chromium.org/2653023004/) I have added proto dependancy check to buildtools. This CL updates PRESUBMIT to use them. BUG= 684383 Review-Url: https://codereview.chromium.org/2651553006 Cr-Commit-Position: refs/heads/master@{#461380} [modify] https://crrev.com/08acd23b2515d32a9f107a5d71555d7b2270c0f8/PRESUBMIT.py |
||
►
Sign in to add a comment |
||
Comment 1 by rhalavati@chromium.org
, Jan 25 2017