New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684379 link

Starred by 1 user
Status: Fixed
Owner:
█ lpromero@chromium.org
No longer actively working on Chrom...
Closed: Jan 2017
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

material-components-ios: remove include_dir src/components/Snackbar/src/private

Project Member Reported by olivierrobin@chromium.org, Jan 24 2017 
A wrong include in material-components-ios force us to add an include dir directive in our BUILD.gn

Remove the workaround once it is fixed upstream.
https://github.com/material-components/material-components-ios/pull/1168

Comment 1 by lpromero@chromium.org, Jan 25 2017

Status: Started (was: Assigned)
Fixed upstream. Waiting for next release and roll.

Uploaded https://codereview.chromium.org/2653923003 to remove the include_dir.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c755988946c0b539cc61cc55d38ae056e0356c27

commit c755988946c0b539cc61cc55d38ae056e0356c27
Author: lpromero <lpromero@chromium.org>
Date: Thu Jan 26 10:16:19 2017

Remove workaround include_dir

The import has been fixed in MDC.

BUG= 684379 
R=olivierrobin@chromium.org

Review-Url: https://codereview.chromium.org/2653923003
Cr-Commit-Position: refs/heads/master@{#446293}

[modify] https://crrev.com/c755988946c0b539cc61cc55d38ae056e0356c27/ios/third_party/material_components_ios/BUILD.gn

Comment 3 by lpromero@chromium.org, Jan 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment