Rotate frames according to camera orientation |
||||||||||||||
Issue descriptionIn ChromeOS, camera orientation information is available in camera_characteristics.conf file. When rotating frames, we should consider both the display rotation and the camera orientation in the config file.
,
Jan 25 2017
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/306b9e55cc83f18e30023e1af00f2f7abc649c6e commit 306b9e55cc83f18e30023e1af00f2f7abc649c6e Author: shenghao <shenghao@chromium.org> Date: Thu Jan 26 09:46:28 2017 Rotate frames according to camera orientation Camera orientation information is available in camera_characteristics.conf file. When rotating frames, we should consider both the display rotation and the camera orientation in the config file. BUG= 684375 , chrome-os-partner:61414 TEST=On reef, verify that back camera shows correct preview when in tablet mode. Review-Url: https://codereview.chromium.org/2648743002 Cr-Commit-Position: refs/heads/master@{#446285} [modify] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/BUILD.gn [rename] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/camera_config_chromeos.cc [rename] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/camera_config_chromeos.h [add] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/camera_config_chromeos_unittest.cc [delete] https://crrev.com/7bab3265dc08756009c0374803bbbdd11fa6a1e8/media/capture/video/linux/camera_facing_chromeos_unittest.cc [modify] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/video_capture_device_chromeos.cc [modify] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/video_capture_device_chromeos.h [modify] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/video_capture_device_factory_linux.cc
,
Jan 26 2017
,
Jan 26 2017
I request to merge https://codereview.chromium.org/2648743002 and https://codereview.chromium.org/2609863004 to m57, since the former depends on the latter.
,
Jan 26 2017
ketakid@ We need to merge this to m57 for Reef. Otherwise, the camera preview will be upside-down. See https://code.google.com/p/chrome-os-partner/issues/detail?id=61414.
,
Jan 26 2017
Approving merge to M57 Chrome OS.
,
Jan 27 2017
,
Jan 28 2017
Sorry. I found we depend on another CL and also need to merge one more CL (three patches in total). https://codereview.chromium.org/2590193002. ketakid@ Please approve this again.
,
Jan 30 2017
Approving merge to M57 Chrome OS.
,
Jan 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b460ef356c93f5784599315d097b3e557bd4ab23 commit b460ef356c93f5784599315d097b3e557bd4ab23 Author: Wu-Cheng Li <wuchengli@google.com> Date: Tue Jan 31 03:01:46 2017 Rotate frames according to camera orientation Camera orientation information is available in camera_characteristics.conf file. When rotating frames, we should consider both the display rotation and the camera orientation in the config file. BUG= 684375 , chrome-os-partner:61414 TEST=On reef, verify that back camera shows correct preview when in tablet mode. Review-Url: https://codereview.chromium.org/2648743002 Cr-Commit-Position: refs/heads/master@{#446285} (cherry picked from commit 306b9e55cc83f18e30023e1af00f2f7abc649c6e) Review-Url: https://codereview.chromium.org/2669513002 . Cr-Commit-Position: refs/branch-heads/2987@{#213} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/BUILD.gn [rename] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/camera_config_chromeos.cc [rename] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/camera_config_chromeos.h [add] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/camera_config_chromeos_unittest.cc [delete] https://crrev.com/09d60fcf9d6f8b85a5172e39befb50b617ef40bd/media/capture/video/linux/camera_facing_chromeos_unittest.cc [modify] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/video_capture_device_chromeos.cc [modify] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/video_capture_device_chromeos.h [modify] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/video_capture_device_factory_linux.cc
,
Jan 31 2017
All three are merged. https://codereview.chromium.org/2667763003/ https://codereview.chromium.org/2663143002/ https://codereview.chromium.org/2669513002/
,
Feb 2 2017
The first M57 that has the fix is 9202.13.0 / 57.0.2987.20.
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by shenghao@chromium.org
, Jan 25 2017