New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684375 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Rotate frames according to camera orientation

Project Member Reported by shenghao@chromium.org, Jan 24 2017

Issue description

In ChromeOS, camera orientation information is available in
camera_characteristics.conf file. When rotating frames, we should
consider both the display rotation and the camera orientation in the
config file.


 

Comment 2 by mcasas@chromium.org, Jan 25 2017

Cc: mcasas@chromium.org
Components: Blink>GetUserMedia>Webcam
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/306b9e55cc83f18e30023e1af00f2f7abc649c6e

commit 306b9e55cc83f18e30023e1af00f2f7abc649c6e
Author: shenghao <shenghao@chromium.org>
Date: Thu Jan 26 09:46:28 2017

Rotate frames according to camera orientation

Camera orientation information is available in
camera_characteristics.conf file. When rotating frames, we should
consider both the display rotation and the camera orientation in the
config file.

BUG= 684375 , chrome-os-partner:61414
TEST=On reef, verify that back camera shows correct preview when in
tablet mode.

Review-Url: https://codereview.chromium.org/2648743002
Cr-Commit-Position: refs/heads/master@{#446285}

[modify] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/BUILD.gn
[rename] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/camera_config_chromeos.cc
[rename] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/camera_config_chromeos.h
[add] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/camera_config_chromeos_unittest.cc
[delete] https://crrev.com/7bab3265dc08756009c0374803bbbdd11fa6a1e8/media/capture/video/linux/camera_facing_chromeos_unittest.cc
[modify] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/video_capture_device_chromeos.cc
[modify] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/video_capture_device_chromeos.h
[modify] https://crrev.com/306b9e55cc83f18e30023e1af00f2f7abc649c6e/media/capture/video/linux/video_capture_device_factory_linux.cc

Labels: Merge-Request-57
I request to merge https://codereview.chromium.org/2648743002 and https://codereview.chromium.org/2609863004 to m57, since the former depends on the latter.
Cc: keta...@chromium.org agnescheng@chromium.org hennessywill@chromium.org
ketakid@ We need to merge this to m57 for Reef. Otherwise, the camera preview will be upside-down. See https://code.google.com/p/chrome-os-partner/issues/detail?id=61414.
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Cc: wuchengli@chromium.org
Labels: -Merge-Approved-57 Merge-Request-57
Sorry. I found we depend on another CL and also need to merge one more CL (three patches in total). https://codereview.chromium.org/2590193002. ketakid@ Please approve this again.
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 31 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b460ef356c93f5784599315d097b3e557bd4ab23

commit b460ef356c93f5784599315d097b3e557bd4ab23
Author: Wu-Cheng Li <wuchengli@google.com>
Date: Tue Jan 31 03:01:46 2017

Rotate frames according to camera orientation

Camera orientation information is available in
camera_characteristics.conf file. When rotating frames, we should
consider both the display rotation and the camera orientation in the
config file.

BUG= 684375 , chrome-os-partner:61414
TEST=On reef, verify that back camera shows correct preview when in
tablet mode.

Review-Url: https://codereview.chromium.org/2648743002
Cr-Commit-Position: refs/heads/master@{#446285}
(cherry picked from commit 306b9e55cc83f18e30023e1af00f2f7abc649c6e)

Review-Url: https://codereview.chromium.org/2669513002 .
Cr-Commit-Position: refs/branch-heads/2987@{#213}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/BUILD.gn
[rename] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/camera_config_chromeos.cc
[rename] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/camera_config_chromeos.h
[add] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/camera_config_chromeos_unittest.cc
[delete] https://crrev.com/09d60fcf9d6f8b85a5172e39befb50b617ef40bd/media/capture/video/linux/camera_facing_chromeos_unittest.cc
[modify] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/video_capture_device_chromeos.cc
[modify] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/video_capture_device_chromeos.h
[modify] https://crrev.com/b460ef356c93f5784599315d097b3e557bd4ab23/media/capture/video/linux/video_capture_device_factory_linux.cc

The first M57 that has the fix is 9202.13.0 / 57.0.2987.20.

Comment 14 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 15 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 17 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment