New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684358 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 24 2017

Issue description

"ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlFeHRlbnNpb25CaW5kaW5nc0FwaVRlc3QuRXhjZXB0aW9uSW5IYW5kbGVyU2hvdWxkTm90Q3Jhc2gM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Sample failure:

@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash (run #3):@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@[ RUN      ] ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@Xlib:  extension "RANDR" missing on display ":99".@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@Xlib:  extension "RANDR" missing on display ":99".@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@[29243:29243:0124/063625.076687:WARNING:audio_manager.cc(321)] Multiple instances of AudioManager detected@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@[29243:29243:0124/063625.076738:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@[29243:29243:0124/063625.112991:WARNING:password_store_factory.cc(247)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@[29243:29243:0124/063625.483989:INFO:CONSOLE(0)] "[SUCCESS] tabsCreateThrowsError", source: chrome-extension://jphkeljbndojchodmpidhnkpbhmikmoa/page.html (0)@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@[29243:29273:0124/063625.501778:WARNING:simple_synchronous_entry.cc(1054)] Could not open platform files for entry.@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@[29243:29243:0124/063625.514364:INFO:CONSOLE(0)] "[SUCCESS] tabsOnCreatedThrowsError", source: chrome-extension://jphkeljbndojchodmpidhnkpbhmikmoa/page.html (0)@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@[29243:29243:0124/063625.527750:INFO:CONSOLE(0)] "[SUCCESS] permissionsGetAllThrowsError", source: chrome-extension://jphkeljbndojchodmpidhnkpbhmikmoa/page.html (0)@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@[29243:29243:0124/063625.585578:FATAL:ipc_mojo_bootstrap.cc(487)] Check failed: endpoint->closed().@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#0 0x000002cc508e base::debug::StackTrace::StackTrace()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#1 0x000002cdd74b logging::LogMessage::~LogMessage()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#2 0x000003f481a9 IPC::(anonymous namespace)::ChannelAssociatedGroupController::~ChannelAssociatedGroupController()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#3 0x000003f48349 IPC::(anonymous namespace)::ChannelAssociatedGroupController::~ChannelAssociatedGroupController()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#4 0x000003e7d179 mojo::internal::SerializationContext::~SerializationContext()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#5 0x00000264e5c1 content::RenderProcessHostImpl::~RenderProcessHostImpl()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#6 0x00000264e899 content::RenderProcessHostImpl::~RenderProcessHostImpl()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#7 0x000002d70cde base::debug::TaskAnnotator::RunTask()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#8 0x000002ce4cad base::MessageLoop::RunTask()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#9 0x000002ce5366 base::MessageLoop::DoWork()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#10 0x000002ce71f9 base::MessagePumpGlib::Run()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#11 0x000002ce4a05 base::MessageLoop::RunHandler()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#12 0x000002d0cc0c base::RunLoop::Run()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#13 0x0000033c502c content::RunMessageLoop()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#14 0x000002d9a40f InProcessBrowserTest::QuitBrowsers()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#15 0x000002d9a0bb InProcessBrowserTest::RunTestOnMainThreadLoop()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#16 0x000003394c06 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#17 0x0000031c90d5 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#18 0x0000031c7fd1 ChromeBrowserMainParts::PreMainMessageLoopRun()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#19 0x0000023679f5 content::BrowserMainLoop::PreMainMessageLoopRun()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#20 0x000002742e16 content::StartupTaskRunner::RunAllTasksNow()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#21 0x00000236589b content::BrowserMainLoop::CreateStartupTasks()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#22 0x00000236afca content::BrowserMainRunnerImpl::Initialize()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#23 0x000002362c68 content::BrowserMain()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#24 0x000002ca2457 content::RunNamedProcessTypeMain()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#25 0x000002ca2ea6 content::ContentMainRunnerImpl::Run()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#26 0x000002ca18f0 content::ContentMain()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#27 0x000003394510 content::BrowserTestBase::SetUp()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#28 0x000002d982a6 InProcessBrowserTest::SetUp()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#29 0x000003b53718 testing::Test::Run()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#30 0x000003b54650 testing::TestInfo::Run()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#31 0x000003b54ae7 testing::TestCase::Run()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#32 0x000003b5bda7 testing::internal::UnitTestImpl::RunAllTests()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#33 0x000003b5b9ba testing::UnitTest::Run()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#34 0x000002dab361 base::TestSuite::Run()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#35 0x000002cb73e8 ChromeTestSuiteRunner::RunTestSuite()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#36 0x0000033c18ec content::LaunchTests()@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#37 0x000002cb7367 main@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#38 0x7f7e35dd97ed __libc_start_main@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@#39 0x0000005f2b81 <unknown>@@@
@@@STEP_LOG_LINE@ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash@@@@
No obvious culprits. I will disable the test.

Wild guess: I wonder if it's related to https://codereview.chromium.org/2649573004/
Cc: yzshen@chromium.org

Comment 4 by yzshen@chromium.org, Jan 24 2017

 Issue 684229  has been merged into this issue.

Comment 5 by yzshen@chromium.org, Jan 24 2017

Owner: yzshen@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f611080eb86df037b4e687dc9d2821d68721d724

commit f611080eb86df037b4e687dc9d2821d68721d724
Author: maniscalco <maniscalco@chromium.org>
Date: Tue Jan 24 19:39:22 2017

Disable ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash

Test is flaky. Disable on Linux.

TBR=lazyboy
BUG= 684358 

Review-Url: https://codereview.chromium.org/2658463002
Cr-Commit-Position: refs/heads/master@{#445780}

[modify] https://crrev.com/f611080eb86df037b4e687dc9d2821d68721d724/chrome/browser/extensions/extension_bindings_apitest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dba42598478b220e70da6769c22b34cc1fef884

commit 4dba42598478b220e70da6769c22b34cc1fef884
Author: maniscalco <maniscalco@chromium.org>
Date: Tue Jan 24 19:55:51 2017

Revert of Disable ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash (patchset #2 id:20001 of https://codereview.chromium.org/2658463002/ )

Reason for revert:
Reverting in favor of https://codereview.chromium.org/2656573004/

Original issue's description:
> Disable ExtensionBindingsApiTest.ExceptionInHandlerShouldNotCrash
>
> Test is flaky. Disable on Linux.
>
> TBR=lazyboy
> BUG= 684358 
>
> Review-Url: https://codereview.chromium.org/2658463002
> Cr-Commit-Position: refs/heads/master@{#445780}
> Committed: https://chromium.googlesource.com/chromium/src/+/f611080eb86df037b4e687dc9d2821d68721d724

TBR=lazyboy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 684358 

Review-Url: https://codereview.chromium.org/2650283002
Cr-Commit-Position: refs/heads/master@{#445785}

[modify] https://crrev.com/4dba42598478b220e70da6769c22b34cc1fef884/chrome/browser/extensions/extension_bindings_apitest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e003d59373ed5f176a8b521c15a7fc0a6ff6876f

commit e003d59373ed5f176a8b521c15a7fc0a6ff6876f
Author: yzshen <yzshen@chromium.org>
Date: Tue Jan 24 21:42:17 2017

ChannelAssociatedGroupController: expect that endpoints may not be in closed state during destruction.

This happens when a NotifyPeerEndpointClosed message been received,but (1) the interface ID hasn't been used to create local endpoint handle; and (2) a NotifyEndpointClosedBeforeSent hasn't been received.

BUG= 684358 

Review-Url: https://codereview.chromium.org/2656573004
Cr-Commit-Position: refs/heads/master@{#445829}

[modify] https://crrev.com/e003d59373ed5f176a8b521c15a7fc0a6ff6876f/ipc/ipc_mojo_bootstrap.cc

Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, Jan 25 2017

Detected 5 new flakes for test/step "ExtensionWindowCreateTest.AcceptState". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMAsSBUZsYWtlIiVFeHRlbnNpb25XaW5kb3dDcmVhdGVUZXN0LkFjY2VwdFN0YXRlDA. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Status: Fixed (was: Started)

Sign in to add a comment