[intermittent] result parsing broken due to spurious "END GOOD" |
||||||||||
Issue descriptionWe have a test in the lab that currently always fails. Except the code parsing results sees it otherwise quite regularly. In the Example below it thinks it is passing. The question is where does the first "END GOOD" come from? Its indentation is killing the true end result. https://chromium.git.corp.google.com/chromiumos/third_party/autotest/+blame/1767604a24da3e50386665a8472ffd0c302e4753/tko/parsers/version_1.py#370 I checked and it is not the job that runs before (at least for the parrot_ivb). ----------------------------------------------------- parrot_ivb-release/R58-9206.0.0/bvt-perbuild/component_UpdateFlash https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=419000946 START component_UpdateFlash component_UpdateFlash timestamp=1485038391 localtime=Jan 21 14:39:51 GOOD ---- sysinfo.before timestamp=1485038423 localtime=Jan 21 14:40:23 END GOOD ---- ---- timestamp=1485038423 localtime=Jan 21 14:40:23 START ---- ---- timestamp=1485038440 localtime=Jan 21 14:40:40 GOOD ---- sysinfo.iteration.before timestamp=1485038440 localtime=Jan 21 14:40:40 END GOOD ---- ---- timestamp=1485038440 localtime=Jan 21 14:40:40 START ---- reboot timestamp=1485038446 localtime=Jan 21 14:40:46 GOOD ---- reboot.start timestamp=1485038446 localtime=Jan 21 14:40:46 GOOD ---- reboot.verify timestamp=1485038466 localtime=Jan 21 14:41:06 END GOOD ---- reboot kernel=3.8.11 localtime=Jan 21 14:41:07 timestamp=1485038467 START ---- reboot timestamp=1485038539 localtime=Jan 21 14:42:19 GOOD ---- reboot.start timestamp=1485038539 localtime=Jan 21 14:42:19 GOOD ---- reboot.verify timestamp=1485038559 localtime=Jan 21 14:42:39 END GOOD ---- reboot kernel=3.8.11 localtime=Jan 21 14:42:40 timestamp=1485038560 START ---- ---- timestamp=1485038950 localtime=Jan 21 14:49:10 GOOD ---- sysinfo.iteration.after timestamp=1485038950 localtime=Jan 21 14:49:10 END GOOD ---- ---- timestamp=1485038950 localtime=Jan 21 14:49:10 START ---- reboot timestamp=1485038975 localtime=Jan 21 14:49:35 GOOD ---- reboot.start timestamp=1485038975 localtime=Jan 21 14:49:35 GOOD ---- reboot.verify timestamp=1485038995 localtime=Jan 21 14:49:55 END GOOD ---- reboot kernel=3.8.11 localtime=Jan 21 14:49:56 timestamp=1485038996 START ---- ---- timestamp=1485039027 localtime=Jan 21 14:50:27 GOOD ---- sysinfo.after timestamp=1485039029 localtime=Jan 21 14:50:29 END GOOD ---- ---- timestamp=1485039029 localtime=Jan 21 14:50:29 ERROR component_UpdateFlash component_UpdateFlash timestamp=1485039040 localtime=Jan 21 14:50:40 Failed: download-omaha-component. END ERROR component_UpdateFlash component_UpdateFlash timestamp=1485039040 localtime=Jan 21 14:50:40 More details 01/21 14:50:40.233 ERROR| logging_manager:0626| STATUS: START component_UpdateFlash component_UpdateFlash timestamp=1485038391 localtime=Jan 21 14:39:51 01/21 14:50:40.233 ERROR| logging_manager:0626| parsing partial test component_UpdateFlash component_UpdateFlash 01/21 14:50:40.234 ERROR| logging_manager:0626| RUNNING: RUNNING 01/21 14:50:40.234 ERROR| logging_manager:0626| Subdir: component_UpdateFlash 01/21 14:50:40.234 ERROR| logging_manager:0626| Testname: component_UpdateFlash 01/21 14:50:40.234 ERROR| logging_manager:0626| 01/21 14:50:40.234 ERROR| logging_manager:0626| 01/21 14:50:40.234 ERROR| logging_manager:0626| STATUS: GOOD ---- sysinfo.before timestamp=1485038423 localtime=Jan 21 14:40:23 01/21 14:50:40.235 ERROR| logging_manager:0626| 01/21 14:50:40.235 ERROR| logging_manager:0626| STATUS: END GOOD ---- ---- timestamp=1485038423 localtime=Jan 21 14:40:23 01/21 14:50:40.235 ERROR| logging_manager:0626| parsing test component_UpdateFlash component_UpdateFlash 01/21 14:50:40.235 ERROR| logging_manager:0626| ADD: GOOD 01/21 14:50:40.235 ERROR| logging_manager:0626| Subdir: component_UpdateFlash 01/21 14:50:40.235 ERROR| logging_manager:0626| Testname: component_UpdateFlash 01/21 14:50:40.236 ERROR| logging_manager:0626| 01/21 14:50:40.236 ERROR| logging_manager:0626| 01/21 14:50:40.236 ERROR| logging_manager:0626| STATUS: START ---- ---- timestamp=1485038440 localtime=Jan 21 14:40:40 01/21 14:50:40.236 ERROR| logging_manager:0626| unexpected extra indentation, ignoring 01/21 14:50:40.236 ERROR| logging_manager:0626| 01/21 14:50:40.236 ERROR| logging_manager:0626| STATUS: GOOD ---- sysinfo.iteration.before timestamp=1485038440 localtime=Jan 21 14:40:40 01/21 14:50:40.236 ERROR| logging_manager:0626| unexpected extra indentation, ignoring 01/21 14:50:40.237 ERROR| logging_manager:0626| 01/21 14:50:40.237 ERROR| logging_manager:0626| STATUS: END GOOD ---- ---- timestamp=1485038440 localtime=Jan 21 14:40:40 [...] 01/21 14:50:40.245 ERROR| logging_manager:0626| STATUS: END GOOD ---- ---- timestamp=1485039029 localtime=Jan 21 14:50:29 01/21 14:50:40.245 ERROR| logging_manager:0626| unexpected extra indentation, ignoring 01/21 14:50:40.246 ERROR| logging_manager:0626| 01/21 14:50:40.246 ERROR| logging_manager:0626| STATUS: ERROR component_UpdateFlash component_UpdateFlash timestamp=1485039040 localtime=Jan 21 14:50:40 Failed: download-omaha-component. 01/21 14:50:40.246 ERROR| logging_manager:0626| unexpected extra indentation, ignoring 01/21 14:50:40.246 ERROR| logging_manager:0626| 01/21 14:50:40.246 ERROR| logging_manager:0626| STATUS: END ERROR component_UpdateFlash component_UpdateFlash timestamp=1485039040 localtime=Jan 21 14:50:40 01/21 14:50:40.247 ERROR| logging_manager:0626| unexpected extra indentation, ignoring 01/21 14:50:40.247 ERROR| logging_manager:0626| parsing test ---- SERVER_JOB ----------------------------------------------------- There is another one here nyan_kitty-release/R57-9156.0.0/bvt-perbuild/component_UpdateFlash https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=410506648 START component_UpdateFlash component_UpdateFlash timestamp=1483710624 localtime=Jan 06 05:50:24 START ---- ---- timestamp=1483710672 localtime=Jan 06 05:51:12 GOOD ---- sysinfo.before timestamp=1483710672 localtime=Jan 06 05:51:12 END GOOD ---- ---- timestamp=1483710672 localtime=Jan 06 05:51:12 START ---- ---- timestamp=1483710697 localtime=Jan 06 05:51:37 GOOD ---- sysinfo.iteration.before timestamp=1483710697 localtime=Jan 06 05:51:37 END GOOD ---- ---- timestamp=1483710697 localtime=Jan 06 05:51:37 START ---- reboot timestamp=1483710705 localtime=Jan 06 05:51:45 GOOD ---- reboot.start timestamp=1483710705 localtime=Jan 06 05:51:45 GOOD ---- reboot.verify timestamp=1483710730 localtime=Jan 06 05:52:10 END GOOD ---- reboot kernel=3.10.18 localtime=Jan 06 05:52:12 timestamp=1483710732 START ---- reboot timestamp=1483710834 localtime=Jan 06 05:53:54 GOOD ---- reboot.start timestamp=1483710834 localtime=Jan 06 05:53:54 GOOD ---- reboot.verify timestamp=1483710857 localtime=Jan 06 05:54:17 END GOOD ---- reboot kernel=3.10.18 localtime=Jan 06 05:54:19 timestamp=1483710859 START ---- ---- timestamp=1483711293 localtime=Jan 06 06:01:33 GOOD ---- sysinfo.iteration.after timestamp=1483711294 localtime=Jan 06 06:01:34 END GOOD ---- ---- timestamp=1483711294 localtime=Jan 06 06:01:34 START ---- reboot timestamp=1483711327 localtime=Jan 06 06:02:07 GOOD ---- reboot.start timestamp=1483711327 localtime=Jan 06 06:02:07 GOOD ---- reboot.verify timestamp=1483711349 localtime=Jan 06 06:02:29 END GOOD ---- reboot kernel=3.10.18 localtime=Jan 06 06:02:31 timestamp=1483711351 GOOD ---- sysinfo.after timestamp=1483711400 localtime=Jan 06 06:03:20 END GOOD ---- ---- timestamp=1483711400 localtime=Jan 06 06:03:20 ERROR component_UpdateFlash component_UpdateFlash timestamp=1483711417 localtime=Jan 06 06:03:37 Failed: download-omaha-component. END ERROR component_UpdateFlash component_UpdateFlash timestamp=1483711417 localtime=Jan 06 06:03:37 more details 01/06 06:03:37.550 ERROR| logging_manager:0626| 01/06 06:03:37.550 ERROR| logging_manager:0626| STATUS: GOOD ---- reboot.verify timestamp=1483711349 localtime=Jan 06 06:02:29 01/06 06:03:37.550 ERROR| logging_manager:0626| 01/06 06:03:37.551 ERROR| logging_manager:0626| STATUS: END GOOD ---- reboot kernel=3.10.18 localtime=Jan 06 06:02:31 timestamp=1483711351 01/06 06:03:37.551 ERROR| logging_manager:0626| 01/06 06:03:37.552 ERROR| logging_manager:0626| STATUS: GOOD ---- sysinfo.after timestamp=1483711400 localtime=Jan 06 06:03:20 01/06 06:03:37.552 ERROR| logging_manager:0626| 01/06 06:03:37.552 ERROR| logging_manager:0626| STATUS: END GOOD ---- ---- timestamp=1483711400 localtime=Jan 06 06:03:20 01/06 06:03:37.553 ERROR| logging_manager:0626| parsing test component_UpdateFlash component_UpdateFlash 01/06 06:03:37.553 ERROR| logging_manager:0626| ADD: GOOD 01/06 06:03:37.553 ERROR| logging_manager:0626| Subdir: component_UpdateFlash 01/06 06:03:37.554 ERROR| logging_manager:0626| Testname: component_UpdateFlash 01/06 06:03:37.554 ERROR| logging_manager:0626| 01/06 06:03:37.555 ERROR| logging_manager:0626| 01/06 06:03:37.555 ERROR| logging_manager:0626| STATUS: ERROR component_UpdateFlash component_UpdateFlash timestamp=1483711417 localtime=Jan 06 06:03:37 Failed: download-omaha-component. 01/06 06:03:37.555 ERROR| logging_manager:0626| unexpected extra indentation, ignoring 01/06 06:03:37.556 ERROR| logging_manager:0626| 01/06 06:03:37.556 ERROR| logging_manager:0626| STATUS: END ERROR component_UpdateFlash component_UpdateFlash timestamp=1483711417 localtime=Jan 06 06:03:37 01/06 06:03:37.557 ERROR| logging_manager:0626| unexpected extra indentation, ignoring 01/06 06:03:37.557 ERROR| logging_manager:0626| parsing test ---- SERVER_JOB
,
Jan 27 2017
,
May 21 2017
This still happens. All the CTS tests in R59 should be failing, but once in a while one passes: https://wmatrix.googleplex.com/unfiltered?suites=arc-cts&releases=59 Example status.log from the test is ok https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/118463043-chromeos-test/chromeos4-row11-rack7-host20/cheets_CTS_N.CtsOsTestCases/ START cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495216667 localtime=May 19 10:57:47 START ---- ---- timestamp=1495216744 localtime=May 19 10:59:04 START cheets_StartAndroid cheets_StartAndroid timestamp=1495216744 localtime=May 19 10:59:04 ERROR cheets_StartAndroid cheets_StartAndroid timestamp=1495216744 localtime=May 19 10:59:04 cheets_StartAndroid: test does not exist END ERROR cheets_StartAndroid cheets_StartAndroid timestamp=1495216745 localtime=May 19 10:59:05 END GOOD ---- ---- timestamp=1495216746 localtime=May 19 10:59:06 FAIL cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495216776 localtime=May 19 10:59:36 cheets_StartAndroid client test did not pass. END FAIL cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495216776 localtime=May 19 10:59:36 But one level up the status log gets confused https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/118463043-chromeos-test/chromeos4-row11-rack7-host20/ START cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495216667 localtime=May 19 10:57:47 START ---- ---- timestamp=1495216684 localtime=May 19 10:58:04 GOOD ---- sysinfo.before timestamp=1495216684 localtime=May 19 10:58:04 END GOOD ---- ---- timestamp=1495216684 localtime=May 19 10:58:04 START ---- ---- timestamp=1495216723 localtime=May 19 10:58:43 GOOD ---- sysinfo.iteration.before timestamp=1495216723 localtime=May 19 10:58:43 END GOOD ---- ---- timestamp=1495216723 localtime=May 19 10:58:43 GOOD ---- sysinfo.iteration.after timestamp=1495216756 localtime=May 19 10:59:16 END GOOD ---- ---- timestamp=1495216756 localtime=May 19 10:59:16 START ---- ---- timestamp=1495216767 localtime=May 19 10:59:27 GOOD ---- sysinfo.after timestamp=1495216768 localtime=May 19 10:59:28 END GOOD ---- ---- timestamp=1495216768 localtime=May 19 10:59:28 FAIL cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495216776 localtime=May 19 10:59:36 cheets_StartAndroid client test did not pass. END FAIL cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495216776 localtime=May 19 10:59:36
,
May 21 2017
For comparison properly failing/intended is https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/118462711-chromeos-test/chromeos4-row11-rack8-host4/ START cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495199788 localtime=May 19 06:16:28 START ---- ---- timestamp=1495199860 localtime=May 19 06:17:40 START cheets_StartAndroid cheets_StartAndroid timestamp=1495199860 localtime=May 19 06:17:40 ERROR cheets_StartAndroid cheets_StartAndroid timestamp=1495199860 localtime=May 19 06:17:40 cheets_StartAndroid: test does not exist END ERROR cheets_StartAndroid cheets_StartAndroid timestamp=1495199860 localtime=May 19 06:17:40 END GOOD ---- ---- timestamp=1495199862 localtime=May 19 06:17:42 FAIL cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495199888 localtime=May 19 06:18:08 cheets_StartAndroid client test did not pass. END FAIL cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495199888 localtime=May 19 06:18:08 START cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495199788 localtime=May 19 06:16:28 START ---- ---- timestamp=1495199805 localtime=May 19 06:16:45 GOOD ---- sysinfo.before timestamp=1495199805 localtime=May 19 06:16:45 END GOOD ---- ---- timestamp=1495199805 localtime=May 19 06:16:45 START ---- ---- timestamp=1495199835 localtime=May 19 06:17:15 GOOD ---- sysinfo.iteration.before timestamp=1495199835 localtime=May 19 06:17:15 END GOOD ---- ---- timestamp=1495199835 localtime=May 19 06:17:15 START ---- ---- timestamp=1495199871 localtime=May 19 06:17:51 GOOD ---- sysinfo.iteration.after timestamp=1495199871 localtime=May 19 06:17:51 END GOOD ---- ---- timestamp=1495199871 localtime=May 19 06:17:51 START ---- ---- timestamp=1495199881 localtime=May 19 06:18:01 GOOD ---- sysinfo.after timestamp=1495199881 localtime=May 19 06:18:01 END GOOD ---- ---- timestamp=1495199882 localtime=May 19 06:18:02 FAIL cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495199888 localtime=May 19 06:18:08 cheets_StartAndroid client test did not pass. END FAIL cheets_CTS_N.CtsOsTestCases cheets_CTS_N.CtsOsTestCases timestamp=1495199888 localtime=May 19 06:18:08
,
May 21 2017
I think from the examples we can conclude that sysinfo.before and sysinfo.iteration.after are often not indented properly and lacking the START clause. My guess is that autotest, even though it seems to run each task sequentially, must have a race when printing to the different log files. One suggestion to clean this up is to not rely on proper formatting. I think parsing and understand what happens would be much more robust if we would give each START/END pair a random token for identification. This could protect from other jobs writing to the same log (lxc should make this impossible but I sometimes see a mode in the lab where autotest tries to run tests even though lxc failed to start). Or at least attach the indentation level as a number to each START/END pair, then we don't rely on counting tabs. Strangely enough the number of tabs is consistently one to little in the failing case.
,
May 21 2017
,
Jul 6 2017
I took a look at this. I think it is sad that we're trusting indentation for something this important. I'm going to slowly hack away at this. I think this is a P2 since it doesn't cause major outages / nothing new has happened to make it worse than in the last 3-4 years. plan of action: - simplify client job by dropping some dead features that require persisting job state to disk (this is making adding new stuff like the record tags hard) - Merge job record generater for client and server jobs into one (the only reason it's different is the complexity metnioned above - [tiny] Make it more semantic (don't accept string statuses, instead use an enum) - Start dropping a new-style record along with the current one that uses uid tags - Add context manager support for uid tags for easy start-end block writing. - replace all ad-hocs parsing of record lines to use the record parsing functions - Stop spewing the old style record lines.
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/87fecd1dcfdec1d77ac717d0d8efc81936409da2 commit 87fecd1dcfdec1d77ac717d0d8efc81936409da2 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Jul 10 22:27:25 2017 [autotest] Make _get_job_data class method BUG= chromium:684311 TEST=unittests Change-Id: I8db532aaa42da694c083bdff195affc1584fc758 Reviewed-on: https://chromium-review.googlesource.com/562219 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/87fecd1dcfdec1d77ac717d0d8efc81936409da2/server/server_job.py [modify] https://crrev.com/87fecd1dcfdec1d77ac717d0d8efc81936409da2/server/site_server_job.py
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/68dbdccbd1e64ad50c69fcb7fa2a5ca2788bb849 commit 68dbdccbd1e64ad50c69fcb7fa2a5ca2788bb849 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Jul 10 22:27:22 2017 [autotest] Report metric about client control file section executed This metric will be used to validate the claim that no tests in practice use more than one section. If true, this allows us to clean up a lot of dead code around this feature, simplifying client tests greatly. BUG= chromium:684311 TEST=None Change-Id: I72041f1b45eca8af00fd6c32caab680e71abb7bc Reviewed-on: https://chromium-review.googlesource.com/562658 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/68dbdccbd1e64ad50c69fcb7fa2a5ca2788bb849/server/autotest.py
,
Jul 12 2017
Re #9: http://shortn/_YH5VMHhSVD is the graph proving that sections are not used in the client tests, and the whole feature can be gutted (I'm in the process of yak shaving).
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/20ea106295a4a2fde5b7d1d976b40e607c75ca71 commit 20ea106295a4a2fde5b7d1d976b40e607c75ca71 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Jul 14 02:46:11 2017 [autotest] Merge site_server_job BUG= chromium:684311 TEST=unittests, moblab trybot Change-Id: I2528c2166c7753040d5799fad030e94f757e5590 Reviewed-on: https://chromium-review.googlesource.com/562220 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/20ea106295a4a2fde5b7d1d976b40e607c75ca71/server/server_job.py [modify] https://crrev.com/20ea106295a4a2fde5b7d1d976b40e607c75ca71/server/server_job_unittest.py [modify] https://crrev.com/20ea106295a4a2fde5b7d1d976b40e607c75ca71/server/site_server_job_utils.py [delete] https://crrev.com/0c93b86dc6a834857e1a18af7feb3945c4dd3d67/server/site_server_job.py
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b41324a410ad2ffc24c561efc62ef910c66d49d7 commit b41324a410ad2ffc24c561efc62ef910c66d49d7 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Jul 14 02:46:00 2017 Explicitly import autotest modules BUG= chromium:684311 TEST=unittests Change-Id: I681780cc800f5f47be29a87cfc135d0d0444092b Reviewed-on: https://chromium-review.googlesource.com/565740 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/b41324a410ad2ffc24c561efc62ef910c66d49d7/client/cros/sys_power.py
,
Jul 14 2017
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1722554376440b8d7d0068e83cdce7cc923b23a4 commit 1722554376440b8d7d0068e83cdce7cc923b23a4 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jul 19 04:50:31 2017 [autotest] Drop support for running background autotest tests. Because feature creep. There is only one user, and there has been only one user for years. This is adding maintenance burden so drop the feature. Also, executing code on the DUT that outlives the server-side test that triggered is unsupported. BUG= chromium:684311 TEST=(1) unittests (2) Run a client test locally Change-Id: I2b7290e44534c6f961bd97442f12d9c0917f4d02 Reviewed-on: https://chromium-review.googlesource.com/562586 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/1722554376440b8d7d0068e83cdce7cc923b23a4/server/autotest.py [modify] https://crrev.com/1722554376440b8d7d0068e83cdce7cc923b23a4/server/autotest_unittest.py
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5d1c546c9611c4bd17c7ede9f9aa7e0e83097c4b commit 5d1c546c9611c4bd17c7ede9f9aa7e0e83097c4b Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jul 19 04:50:32 2017 [autotest] Drop server-side support for multi-section client tests This CL removes the server side autotest support for client tests with multiple steps. Follow up CLs will remove the client side support. This is a dead feature that duplicates functionality intended to be used via server-side tests. BUG= chromium:684311 TEST=(1) unittests (2) Run a client test locally. Change-Id: I7df7a1bfb2bdba8a26b45f6e7b341922f45804e4 Reviewed-on: https://chromium-review.googlesource.com/562587 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/5d1c546c9611c4bd17c7ede9f9aa7e0e83097c4b/server/autotest.py
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/54905418c66f0e6bdad0b7ae14c50d47927e8481 commit 54905418c66f0e6bdad0b7ae14c50d47927e8481 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jul 19 04:50:32 2017 Add __eq__ to error.CmdError and utils.CmdResult BUG= chromium:684311 TEST=None Change-Id: I9a17e7294b9ee19419c7e11bf7534e19d5d4205c Reviewed-on: https://chromium-review.googlesource.com/567760 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/54905418c66f0e6bdad0b7ae14c50d47927e8481/client/common_lib/error.py [modify] https://crrev.com/54905418c66f0e6bdad0b7ae14c50d47927e8481/client/common_lib/utils.py
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cb4f54963f755520254a01d9c8a6bcde65808853 commit cb4f54963f755520254a01d9c8a6bcde65808853 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Jul 28 00:55:42 2017 Revert "[autotest] Drop server-side support for multi-section client tests" This reverts commit 5d1c546c9611c4bd17c7ede9f9aa7e0e83097c4b. Reason for revert: On top of CL:562586, which needs to be reverted Original change's description: > [autotest] Drop server-side support for multi-section client tests > > This CL removes the server side autotest support for client tests with > multiple steps. Follow up CLs will remove the client side support. > > This is a dead feature that duplicates functionality intended to be used > via server-side tests. > > BUG= chromium:684311 > TEST=(1) unittests > (2) Run a client test locally. > > Change-Id: I7df7a1bfb2bdba8a26b45f6e7b341922f45804e4 > Reviewed-on: https://chromium-review.googlesource.com/562587 > Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> > Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> > Reviewed-by: Xixuan Wu <xixuan@chromium.org> BUG= chromium:684311 BUG= chromium:749198 Change-Id: Id777838151c9a26015fe9bd8c5ee6b7e35fd638b Reviewed-on: https://chromium-review.googlesource.com/586432 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/cb4f54963f755520254a01d9c8a6bcde65808853/server/autotest.py
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/beaee90065f9352067981d8cb1bc631d24c5a17f commit beaee90065f9352067981d8cb1bc631d24c5a17f Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Jul 28 00:55:42 2017 Revert "[autotest] Drop support for running background autotest tests." This reverts commit 1722554376440b8d7d0068e83cdce7cc923b23a4. Reason for revert: There are still users of this feature in the wild, which I missed. Original change's description: > Because feature creep. There is only one user, and there has been only > one user for years. This is adding maintenance burden so drop the > feature. > Also, executing code on the DUT that outlives the server-side test that > triggered is unsupported. > BUG= chromium:684311 > TEST=(1) unittests > (2) Run a client test locally > Change-Id: I2b7290e44534c6f961bd97442f12d9c0917f4d02 > Reviewed-on: https://chromium-review.googlesource.com/562586 > Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> > Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> > Reviewed-by: Xixuan Wu <xixuan@chromium.org> BUG= chromium:684311 BUG= chromium:749198 Change-Id: Ic37567e9bc8584b080010e7a501fe6204c7df66f Reviewed-on: https://chromium-review.googlesource.com/587333 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org> [modify] https://crrev.com/beaee90065f9352067981d8cb1bc631d24c5a17f/server/autotest.py [modify] https://crrev.com/beaee90065f9352067981d8cb1bc631d24c5a17f/server/autotest_unittest.py
,
Jul 28 2017
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b8e428f992b16c8ddd5a1e0eaea1cb8b5645b73c commit b8e428f992b16c8ddd5a1e0eaea1cb8b5645b73c Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Aug 01 21:07:47 2017 Revert "[autotest] Drop server-side support for multi-section client tests" This reverts commit 5d1c546c9611c4bd17c7ede9f9aa7e0e83097c4b. Reason for revert: On top of CL:562586, which needs to be reverted Original change's description: > [autotest] Drop server-side support for multi-section client tests > > This CL removes the server side autotest support for client tests with > multiple steps. Follow up CLs will remove the client side support. > > This is a dead feature that duplicates functionality intended to be used > via server-side tests. > > BUG= chromium:684311 > TEST=(1) unittests > (2) Run a client test locally. > > Change-Id: I7df7a1bfb2bdba8a26b45f6e7b341922f45804e4 > Reviewed-on: https://chromium-review.googlesource.com/562587 > Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> > Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> > Reviewed-by: Xixuan Wu <xixuan@chromium.org> BUG= chromium:684311 BUG= chromium:749198 Change-Id: Id777838151c9a26015fe9bd8c5ee6b7e35fd638b Reviewed-on: https://chromium-review.googlesource.com/586432 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/596835 Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/b8e428f992b16c8ddd5a1e0eaea1cb8b5645b73c/server/autotest.py
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e3d2d75310d28f0311e850823f9399aba1457968 commit e3d2d75310d28f0311e850823f9399aba1457968 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Tue Aug 01 21:08:05 2017 Revert "[autotest] Drop support for running background autotest tests." This reverts commit 1722554376440b8d7d0068e83cdce7cc923b23a4. Reason for revert: There are still users of this feature in the wild, which I missed. Original change's description: > Because feature creep. There is only one user, and there has been only > one user for years. This is adding maintenance burden so drop the > feature. > Also, executing code on the DUT that outlives the server-side test that > triggered is unsupported. > BUG= chromium:684311 > TEST=(1) unittests > (2) Run a client test locally > Change-Id: I2b7290e44534c6f961bd97442f12d9c0917f4d02 > Reviewed-on: https://chromium-review.googlesource.com/562586 > Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> > Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> > Reviewed-by: Xixuan Wu <xixuan@chromium.org> BUG= chromium:684311 BUG= chromium:749198 Change-Id: Ic37567e9bc8584b080010e7a501fe6204c7df66f Reviewed-on: https://chromium-review.googlesource.com/587333 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/596836 Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/e3d2d75310d28f0311e850823f9399aba1457968/server/autotest.py [modify] https://crrev.com/e3d2d75310d28f0311e850823f9399aba1457968/server/autotest_unittest.py
,
Aug 22 2017
I think I found another avatar of this problem: If log collection throws an exception, it can leave the logs in an unparsable status due to this bug. Example: https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/136377023-chromeos-test/chromeos6-row1-rack6-host15/debug/ https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/136377023-chromeos-test/chromeos6-row1-rack6-host15/debug/
,
Aug 22 2017
,
May 14 2018
Can't justify cost-benefit here, for now. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by pprabhu@chromium.org
, Jan 25 2017Status: Unconfirmed (was: Untriaged)