New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684296 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
M57



Sign in to add a comment

Allow video only elements to be paused even if they have large keyframe distance.

Project Member Reported by avayvod@chromium.org, Jan 24 2017

Issue description

Tracking issue to merge https://codereview.chromium.org/2643033004 to M57.

My recent change https://codereview.chromium.org/2631633003 enabled
playing background video-only players on Android if they meet various
criteria like being shorter than an experimental limit or having
frequent enough keyframes.

The change is already submitted as:

Commit: ac1a85217d72b0043dfb41b447afe4f05d0d5588
Cr-Commit-Position: refs/heads/master@{#445116}
 
Cc: amineer@chromium.org
Cc: -amineer@chromium.org
Labels: -Merge-Request-57 Merge-Approved-57
Merge approved for M57 branch 2987.
Labels: -Merge-Approved-57 merge-merged-57
Status: Fixed (was: Started)
Committed patchset #1 (id:1) manually as
47a2344d1df3addf7290e5d7ca4640f83e75d134.

Description:
[Video, Android] Pause video only players ignoring duration and keyframes

My recent change https://codereview.chromium.org/2631633003 enabled
playing background video-only players on Android if they meet various
criteria like being shorter than an experimental limit or having
frequent enough keyframes.

Restore pausing logic by bypassing the irrelevant checks on Android.

BUG=None
TEST=Manual + updated unit tests

Review-Url: https://codereview.chromium.org/2643033004
Cr-Commit-Position: refs/heads/master@{#445116}
(cherry picked from commit ac1a85217d72b0043dfb41b447afe4f05d0d5588)

Review-Url: https://codereview.chromium.org/2655723002 .
Cr-Commit-Position: refs/branch-heads/2987@{#57}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/47a2344d1df3addf7290e5d7ca4640f83e75d134

Affected files (+20, -2 lines):
M media/blink/webmediaplayer_impl.cc
M media/blink/webmediaplayer_impl_unittest.cc

Sign in to add a comment