New issue
Advanced search Search tips

Issue 684294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[WPT Export] Raises Exception('PR could not be merged') even though PR was merged

Project Member Reported by jeffcarp@chromium.org, Jan 24 2017

Issue description

Full logs:

Merging...
PR merged! Deleting branch.
Traceback (most recent call last):
  File "../../wpt-export", line 42, in <module>
    main()
  File "../../wpt-export", line 38, in main
    test_exporter.run()
  File "/usr/local/google/home/jeffcarp/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 32, in run
    self.merge_in_flight_pull_request(pull_requests.pop())
  File "/usr/local/google/home/jeffcarp/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py", line 59, in merge_in_flight_pull_request
    self.wpt_github.delete_remote_branch('chromium-export-try')
  File "/usr/local/google/home/jeffcarp/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py", line 104, in delete_remote_branch
    raise Exception('PR could not be merged')
Exception: PR could not be merged

 
Status: Started (was: Assigned)
I believe this is because it's expecting the wrong status code. We expect 200 but DELETE returns 204. https://developer.github.com/v3/git/refs/#delete-a-reference

CL uploaded https://codereview.chromium.org/2657523005

Status: Fixed (was: Started)
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment