New issue
Advanced search Search tips

Issue 684288 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Stream with disabled video track reports 2x2 resolution on loadedmetadata

Reported by and...@tokbox.com, Jan 24 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Steps to reproduce the problem:
1. Load attached page or use https://jsfiddle.net/94posz5s/
2. Note 2x2 for loaded resolution

What is the expected behavior?
Should be the resolution of the actual video, something like 640x480, or perhaps 0x0 since it's disabled.

What went wrong?
Got 2x2 for the resolution, which seems to be a leak of some internal implementation detail.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 55.0.2883.95  Channel: stable
OS Version: OS X 10.12.2
Flash Version:
 
twoByTwoVideo.html
591 bytes View Download
Cc: guidou@chromium.org
Labels: Needs-Feedback
Could this be similar to  issue 682887 

@guidou: Request you to please confirm on the same.

Thanks.!

Comment 2 by and...@tokbox.com, Jan 25 2017

@ranjitkan I think it's pretty different actually. This one has to do with a temporary incorrect report of the resolution at the time of the loadedmetadata event, whereas the other one is about actually getting the wrong resolution.
Labels: -Needs-Feedback Needs-Triage-M58

Comment 4 by guidou@chromium.org, Jan 27 2017

Status: Assigned (was: Unconfirmed)
It's a different bug. I think this 2x2 resolution problem occurs when the camera cannot be opened due to problems such as USB bandwidth issues, but Chromium does not detect it as an error.
I will look into it and triage further is necessary.

Comment 5 by guidou@chromium.org, Jan 27 2017

Owner: guidou@chromium.org
Cc: ligim...@chromium.org
Labels: M-59
M58 stable is approaching soon, can we have a fix before M59 hits stable.

Comment 7 by guidou@chromium.org, Apr 18 2017

This is fixed on M59.
Status: Fixed (was: Assigned)
Closing as per #7.

Comment 9 by a...@tokbox.com, Jun 21 2017

This is still an issue for me with Chrome#59 59.0.3071.104. Should it be fixed with this build? In the jsfiddle I still get 2x2.
Status: Assigned (was: Fixed)
Reopening as per comment #9
Labels: -M-59 -Needs-Triage-M58 M-60
Labels: -M-60 M-61
Labels: -M-61 M-62
Owner: orphis@chromium.org
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/447c696aaf19064a79d7bc894ce4a0aa3422c69c

commit 447c696aaf19064a79d7bc894ce4a0aa3422c69c
Author: Florent Castelli <orphis@chromium.org>
Date: Mon Dec 11 19:09:35 2017

Don't trigger end of track when starting a new disabled track

Fix reporting a size of 2x2 on the video element during the loading
phase.

Bug: 684288
Change-Id: Id4adceefaf4c3df57a1ba41fd285862d72792b1a
Reviewed-on: https://chromium-review.googlesource.com/806215
Commit-Queue: Florent Castelli <orphis@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523152}
[modify] https://crrev.com/447c696aaf19064a79d7bc894ce4a0aa3422c69c/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/447c696aaf19064a79d7bc894ce4a0aa3422c69c/content/renderer/media/media_stream_video_renderer_sink.cc
[modify] https://crrev.com/447c696aaf19064a79d7bc894ce4a0aa3422c69c/content/test/data/media/getusermedia.html

Status: Fixed (was: Assigned)

Comment 17 by tommi@chromium.org, Feb 17 2018

0x0 seems like a reasonable resolution to report for disabled tracks if a resolution must be reported.

The fix for this issue might have caused  issue 403710  (and  issue 813243 ) to regress since the fix only removes the line that was there to allow video video elements to start playing audio without waiting for video when the video track is disabled.
Labels: -M-62
Status: Assigned (was: Fixed)
Reopening since we are reverting r523152 due to a regression.
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1f07e92571d6a2db9ee116c267c2963f7b091ba

commit d1f07e92571d6a2db9ee116c267c2963f7b091ba
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon Feb 19 18:14:35 2018

Revert "Don't trigger end of track when starting a new disabled track"

This reverts commit 447c696aaf19064a79d7bc894ce4a0aa3422c69c.

Reason for revert: Introduces a regression. See  https://crbug.com/813243 

Original change's description:
> Don't trigger end of track when starting a new disabled track
>
> Fix reporting a size of 2x2 on the video element during the loading
> phase.
>
> Bug: 684288
> Change-Id: Id4adceefaf4c3df57a1ba41fd285862d72792b1a
> Reviewed-on: https://chromium-review.googlesource.com/806215
> Commit-Queue: Florent Castelli <orphis@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523152}

TBR=guidou@chromium.org,orphis@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 684288,  813243 
Change-Id: I60bc092c23d1840a9c7e95b4b1d8d02c52c6fb46
Reviewed-on: https://chromium-review.googlesource.com/924190
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537675}
[modify] https://crrev.com/d1f07e92571d6a2db9ee116c267c2963f7b091ba/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/d1f07e92571d6a2db9ee116c267c2963f7b091ba/content/renderer/media/stream/media_stream_video_renderer_sink.cc
[modify] https://crrev.com/d1f07e92571d6a2db9ee116c267c2963f7b091ba/content/test/data/media/getusermedia.html

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 22 2018

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e62f75e6cdfbd502181616c82032bdcd7eaeb38e

commit e62f75e6cdfbd502181616c82032bdcd7eaeb38e
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu Feb 22 13:04:14 2018

Revert "Don't trigger end of track when starting a new disabled track"

This reverts commit 447c696aaf19064a79d7bc894ce4a0aa3422c69c.

Reason for revert: Introduces a regression. See  https://crbug.com/813243 

Original change's description:
> Don't trigger end of track when starting a new disabled track
>
> Fix reporting a size of 2x2 on the video element during the loading
> phase.
>
> Bug: 684288
> Change-Id: Id4adceefaf4c3df57a1ba41fd285862d72792b1a
> Reviewed-on: https://chromium-review.googlesource.com/806215
> Commit-Queue: Florent Castelli <orphis@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523152}

TBR=guidou@chromium.org, orphis@chromium.org


(cherry picked from commit d1f07e92571d6a2db9ee116c267c2963f7b091ba)

Bug: 684288,  813243 
Change-Id: I60bc092c23d1840a9c7e95b4b1d8d02c52c6fb46
Reviewed-on: https://chromium-review.googlesource.com/924190
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537675}
Reviewed-on: https://chromium-review.googlesource.com/928768
Cr-Commit-Position: refs/branch-heads/3325@{#547}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/e62f75e6cdfbd502181616c82032bdcd7eaeb38e/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/e62f75e6cdfbd502181616c82032bdcd7eaeb38e/content/renderer/media/media_stream_video_renderer_sink.cc
[modify] https://crrev.com/e62f75e6cdfbd502181616c82032bdcd7eaeb38e/content/test/data/media/getusermedia.html

Sign in to add a comment