New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684281 link

Starred by 1 user
Status: WontFix
Owner:
tandrii@chromium.org
Closed: Jan 2017
Cc:
w...@chromium.org
dpranke@chromium.org
█ andyb...@chromium.org
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Gerrit errors are inscrutable

Project Member Reported by dcheng@chromium.org, Jan 24 2017 
I'm trying to revert a CL that breaks owners checks. Unfortunately, there are merge conflicts.

In non-Gerrit, I patch in the CL with git cl patch, rebase it locally, and reupload with git cl upload.

I tried the same thing with Gerrit. git cl patch works, rebasing works, but no matter what I do, I can't seem to reupload:

Presubmit checks took 12.2s to calculate.

Presubmit checks passed.
 presubmit_canned_checks.py  | 4 ++--
 tests/presubmit_unittest.py | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Adding self-LGTM (Code-Review +1) because of TBRs
remote: Processing changes: refs: 1, done
To https://chromium.googlesource.com/chromium/tools/depot_tools.git
 ! [remote rejected]   988a861ad84566df9b0daa87fe65e577ce90dbcf -> refs/for/refs/heads/master%l=Code-Review+1,m=Initial_upload,notify=NONE,r=dpranke@chromium.org,r=wez@chromium.org (internal server error: Error inserting change/patchset)
error: failed to push some refs to 'https://chromium.googlesource.com/chromium/tools/depot_tools.git'
Failed to create a change. Please examine output above for the reason of the failure.

Help?

Comment 1 by w...@chromium.org, Jan 24 2017 

Is it trying to literally git push your branch changes into a server-side
branch for that CL? If so then presumably that won't work because you
rebased - so you probably need to create a clean patch-set (e.g. clear the
CL associated with the branch and re-upload a fresh revert CL..?)

Comment 2 by dcheng@chromium.org, Jan 24 2017 

I've tried both ways. I can't seem to even upload new patchsets.

Comment 3 by andyb...@chromium.org, Jan 24 2017

Cc: aga...@chromium.org tandrii@chromium.org
This is a 500 on Gerrit’s side. Filed bug internally. Will keep this open to dupe against in case of more reports.

Comment 4 by andyb...@chromium.org, Jan 24 2017

Cc: -tandrii@chromium.org andyb...@chromium.org
Owner: tandrii@chromium.org
Assigning to tandrii for Chromium since Munich will be up soon.

Comment 5 by dcheng@chromium.org, Jan 24 2017 

Are there any workarounds? Or am I just out of luck?

Comment 6 by andyb...@chromium.org, Jan 24 2017 

Spoke with dcheng and was able to create a revert myself: https://chromium-review.googlesource.com/c/431581/ 

Internal bug still open.

Comment 7 by dpranke@chromium.org, Jan 24 2017 

I didn't see andybons's change, and reverted it myself in https://chromium-review.googlesource.com/431656 ; sorry for the collision.

Comment 8 by tandrii@chromium.org, Jan 24 2017

Status: WontFix (was: Assigned)
Internal server errors are inscrutable because they are not expected... If it were expected error, it'd have been propagated properly to the user.

A workaround if one can't upload a new patchset is to create a new issue:
git cl issue 0
git cl upload

I'll keep an eye on internal bug. As for this bug, thank you very much for filing, as there is nothing that can be done by chrome infra afais. But if you have something in mind, please re-open.
►

Sign in to add a comment