bluetooth: Devices are marked as connected before they actually connect. |
|||
Issue descriptionIn BluetoothRemoteGATTServer::connect[1] we call bluetooth()->addDevice which adds the device to the map of connected devices. We do this even before we actually connect to the device. We should only add a device to the map once we've established a connection. p.s. We should also change the name to be more descriptive i.e. addToConnectedDevicesMap. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp?sq=package:chromium&dr&rcl=1485202678&l=75
,
Jan 24 2017
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6425162c0931de893c79dc2812ed83c82fb7f07 commit e6425162c0931de893c79dc2812ed83c82fb7f07 Author: juncai <juncai@chromium.org> Date: Tue Jan 24 23:54:48 2017 Mark Bluetooth devices connected after they are actually connected This CL modified code to mark Bluetooth devices connected when the connection is successful. Also changed the function names to be more descriptive. BUG= 684263 Review-Url: https://codereview.chromium.org/2650003005 Cr-Commit-Position: refs/heads/master@{#445865} [modify] https://crrev.com/e6425162c0931de893c79dc2812ed83c82fb7f07/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp [modify] https://crrev.com/e6425162c0931de893c79dc2812ed83c82fb7f07/third_party/WebKit/Source/modules/bluetooth/Bluetooth.h [modify] https://crrev.com/e6425162c0931de893c79dc2812ed83c82fb7f07/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp [modify] https://crrev.com/e6425162c0931de893c79dc2812ed83c82fb7f07/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
,
Jan 24 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by juncai@chromium.org
, Jan 24 2017Owner: juncai@chromium.org
Status: Assigned (was: Available)