New issue
Advanced search Search tips

Issue 684261 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Jan 2017
Cc:
tandrii@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Too easy to lose CL descriptions

Project Member Reported by calamity@chromium.org, Jan 24 2017 
It's currently too easy to lose CL descriptions because of an error occurring in the upload process after you've typed a long description. This is happening 

I propose either:
- Extending the backup system to gerrit (e.g https://chromium-review.googlesource.com/431459)
- Printing the cl description immediately after it's entered so the CL description can be retrieved in the terminal scrollback

Comment 1 by tandrii@chromium.org, Jan 24 2017

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Yep, hits me too.
I think printing isn't such a bad idea, actually, but I like your CL too.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/f732cd5c7020a8bed17dcf444e4e4dd31a4cf086

commit f732cd5c7020a8bed17dcf444e4e4dd31a4cf086
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Jan 24 01:40:11 2017

Add cl description backup to gerrit upload.

BUG= 684261 

Change-Id: I2716864526fcedf44e561be8512843e12810e3a9
Reviewed-on: https://chromium-review.googlesource.com/431459
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f732cd5c7020a8bed17dcf444e4e4dd31a4cf086/git_cl.py
[modify] https://crrev.com/f732cd5c7020a8bed17dcf444e4e4dd31a4cf086/tests/git_cl_test.py

Comment 3 by tandrii@chromium.org, Jan 25 2017

Owner: calamity@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment