New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684227 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 678663



Sign in to add a comment

Downloaded data is kept in memory when background video decoding is disabled

Project Member Reported by avayvod@chromium.org, Jan 24 2017

Issue description

Mentioned by Dale today: we might keep queuing data packets from demuxer (like FfmpegDemuxer) even if the video track is disabled so while lowering the power consumption we might be increasing memory consumption. Need to confirm if that's the case and make sure data packets are not stored if the video track is disabled.
 
For FFmpegDemuxer we do already drop packets for disabled streams (see https://cs.chromium.org/chromium/src/media/filters/ffmpeg_demuxer.cc?rcl=0&l=1754).
For MSE the application is in control of buffering, so we can't prevent video data from being downloaded and appended to MSE SourceBuffer. AFAIR we are not dropping data from disabled ChunkDemuxerStreams for now - we could look into  that.
Hm, IIRC Dale actually told me ChunkDemuxerStream should be fine and I should look into FFmpeg :)
IIRC for MSE (that's what ChunkDemuxer is for), Chrome has a limit on how much the site can append. Site has to discard the chunks that are no longer needed (e.g. the chunks defining the frames before the current position). I wondered if Chrome tries to do that automatically in common cases and if not, why? Also, if we can still do that with the decoder being disabled (relying on audio frame timestamps?).
Status: WontFix (was: Started)
Ah this is fixed then! Thanks servolk@. I couldn't remember and didn't have time to check the video code.

MSE has strict rules about buffered data, so we can't do much about that yet.
Sorry for the noise!

Sign in to add a comment