New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684226 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
█ phajdan.jr@chromium.org
█ katthomas@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Skipping analyze can cause us to miss bugs in analyze

Project Member Reported by dpranke@chromium.org, Jan 24 2017 
This was caused by a bad change landing on the waterfall in 

https://codereview.chromium.org/2627093009

it was reverted in

https://codereview.chromium.org/2648383002

It looks like the problematic CL was missing an entry in gn_isolate_map.pyl, which caused analyze to fail. 

However, because we changed //testing/buildbot/*.json, the recipe's whitelist of "changes we can't analyze" (//testing/buildbot/trybot_analyze_config.json) matched, and so we skipped analyze and didn't detect the bug.

I think we need to change things so that we call analyze unconditionally and fail the build if analyze fails, but if analyze succeeds, *then* check the whitelist and ignore analyze's results. This should be a simple enough change.

In addition, we should work to make sure that the whitelist is as small as possible.

See  crbug.com/684060  for the bug that motivated this one :).
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by dpranke@chromium.org, Feb 12 2018

Status: Fixed (was: Untriaged)
I fixed this at some point, and analyze is always run now (and the results are ignored if we matched the whitelist).
►

Sign in to add a comment