New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684224 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Use front camera by default

Project Member Reported by henryhsu@chromium.org, Jan 24 2017

Issue description

Currently, chromium uses the first camera of the provided list.
But we want user can use front camera by default.

Since JS doesn't have an API to get camera facing, we have to sort the list by facing.
 
Labels: -Pri-3 Pri-1
Labels: OS-Chrome
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9c70e53e5da9b0065ef7f5c6ce78d5b46e49875

commit e9c70e53e5da9b0065ef7f5c6ce78d5b46e49875
Author: henryhsu <henryhsu@chromium.org>
Date: Thu Jan 26 12:35:16 2017

Sort camera device list to use front camera first

Since javascript doesn't have API to get camera facing, we sort the
reported camera device list by facing. Then app can use the front
camera by default.

BUG= 684224 ,chrome-os-partner:61756
TEST=powerwash device and camera app uses the front camera by default.

Review-Url: https://codereview.chromium.org/2648973003
Cr-Commit-Position: refs/heads/master@{#446307}

[modify] https://crrev.com/e9c70e53e5da9b0065ef7f5c6ce78d5b46e49875/media/capture/video/linux/video_capture_device_factory_linux.cc
[modify] https://crrev.com/e9c70e53e5da9b0065ef7f5c6ce78d5b46e49875/media/capture/video/video_capture_device_descriptor.cc
[modify] https://crrev.com/e9c70e53e5da9b0065ef7f5c6ce78d5b46e49875/media/capture/video/video_capture_device_descriptor.h

Labels: Merge-Request-57
Cc: agnescheng@chromium.org keta...@chromium.org hennessywill@chromium.org
ketakid@ We need a merge for this to M57 for Reef. See https://code.google.com/p/chrome-os-partner/issues/detail?id=61756 for details.
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 30 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Merged. https://codereview.chromium.org/2668633002
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 31 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0221ccb1eea16293cff0c0a0cda5a110266a5d5

commit e0221ccb1eea16293cff0c0a0cda5a110266a5d5
Author: Wu-Cheng Li <wuchengli@google.com>
Date: Tue Jan 31 03:05:08 2017

Sort camera device list to use front camera first

Since javascript doesn't have API to get camera facing, we sort the
reported camera device list by facing. Then app can use the front
camera by default.

BUG= 684224 ,chrome-os-partner:61756
TEST=powerwash device and camera app uses the front camera by default.

Review-Url: https://codereview.chromium.org/2648973003
Cr-Commit-Position: refs/heads/master@{#446307}
(cherry picked from commit e9c70e53e5da9b0065ef7f5c6ce78d5b46e49875)

Review-Url: https://codereview.chromium.org/2668633002 .
Cr-Commit-Position: refs/branch-heads/2987@{#214}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/e0221ccb1eea16293cff0c0a0cda5a110266a5d5/media/capture/video/linux/video_capture_device_factory_linux.cc
[modify] https://crrev.com/e0221ccb1eea16293cff0c0a0cda5a110266a5d5/media/capture/video/video_capture_device_descriptor.cc
[modify] https://crrev.com/e0221ccb1eea16293cff0c0a0cda5a110266a5d5/media/capture/video/video_capture_device_descriptor.h

The first M57 that has the fix is 9202.13.0 / 57.0.2987.20.
Issue 695351 has been merged into this issue.

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment